Switch JS Engine from SpiderMonkey to QuickJS#228
Merged
Conversation
The previous approach copied pre-compiled libquickjs.a and pacparser.o from the host (ubuntu-latest) into the manylinux container. This caused auditwheel to fail because the objects were built against a newer glibc than the manylinux ABI allows. Now we copy source files and use CIBW_BEFORE_BUILD to compile libquickjs.a and pacparser.o inside the manylinux container with the appropriate toolchain. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The host pymod build creates artifacts in build/ that cibuildwheel picks up, causing auditwheel to fail. Clean them first. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
manugarg
force-pushed
the
migrate_quickjs
branch
from
803e54b to
6d37603
Compare
|
manugarg
changed the title
manugarg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.