Bunch of stuff#14
Open
Cobollatin wants to merge 1 commit into
Open
Conversation
Owner
|
I'm not reading all of that |
Author
Then approve and merge :) |
|
@Cobollatin Do you have a discord? Would love to chat with you about this project |
Author
Right, sent you cna email. Tho you cna find me in discord with the same username |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, hope this PR finds you well.
I had some time this weekend and was looking for a DarkOrbit server emulator. I found yours and, after running it, it looked like it still needed a good amount of work. I made a set of changes mainly to get a clearer picture of what’s done vs. what’s missing, and to make local testing easier.
.envfile - you can copy from.env.example.gradle.properties.examplefor the required flags - basicallyrunCMSplus the npm path/args (the path/args are only needed if you run nvm on Windows; if not, leave them empty and it works)./logsdepending on the category. I also added an XML config.vendorsfolder where devs can put the needed JavaFX jars/SDK and reference them from the IDE. This isn’t necessary when running with Gradle directly, but for an IDE (IntelliJ in my case) you need to include those in the VM options. I added instructions in the README as well.@EventListenersystem the other services use. It was a pain setting up an isolated Spring context and getting all the endpoints working. This still needs more testing, but at least Spring doesn’t crash.CMS.java- it just callsnpm run serve.structure.sqlfirst, thenrelations.sql, and finallydump.sql.Some stuff that still needs to be addressed: some
dump.sqlscripts fail (haven’t looked into this yet - Hibernate reports “syntax error”). Also, some JPA operations fail: when I try to use the register endpoint, Hibernate reports aData truncated for column IDerror when trying to save an account.Please take your time reviewing this PR. I don’t think I’ll have time during the week; I should be available again next weekend if you request changes.