Repository navigation
ci: use an absolute bundle output dir in the release workflow - #13
Merged
Merged
Conversation
MSBuild resolves a relative -p:AppxPackageDir against the project folder, so the v0.1.4 tag build wrote UnityExtension/UnityExtension/BundleArtifacts while the 'Find MSIX bundle' step searched UnityExtension/BundleArtifacts and failed. Make PACKAGE_DIR absolute in release-msix.yml and pass the same override in the PR bundle-build job so this path logic is exercised before a tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v0.1.4tag build (run 38843566297) built the bundle but failed at "Find MSIX bundle": MSBuild resolved the relative-p:AppxPackageDir=UnityExtension\BundleArtifacts\against the project folder, so the bundle was written toUnityExtension\UnityExtension\BundleArtifacts\while the step searchedUnityExtension\BundleArtifacts\from the repo root.Fix
release-msix.yml:PACKAGE_DIRis now${{ github.workspace }}\UnityExtension\BundleArtifacts(absolute).ci.ymlbundle-build: pass the sameAppxPackageDiroverride and look for the bundle there, so this path logic is covered on PRs.Verification
actionlintpasses.-p:AppxPackageDirwritesUnityExtension_0.1.4.0_x64_arm64.msixbundleunder that directory.bundle-buildjob exercises the CI form.After merge,
v0.1.4has to be re-pointed at the newmaster(the tag ruleset blocks deletion).