Repository navigation
ci: trust the signing cert before verify; add a no-publish dry run - #14
Merged
Merged
Conversation
The v0.1.4 tag build failed at 'Verify MSIX bundle' (SignTool: root not trusted) because the self-signed cert is unknown on a clean runner. Import it into LocalMachine\TrustedPeople first. Add workflow_dispatch as a dry run that builds, signs, verifies and uploads the artifact; the GitHub release and store-publish steps are tag-only, and the version check compares the project files against each other when there is no tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
v0.1.4tag build (run 38844254594) got through build, find and sign, then failed at "Verify MSIX bundle": SignTool reported the self-signed root as not trusted on the clean runner. This release workflow had never succeeded before (v0.1.1 predates it), so each step was untested.Changes
.cerintoLocalMachine\TrustedPeoplebeforesigntool verify /pa.workflow_dispatchas a dry run: builds, signs, verifies and uploads the artifact. The GitHub release step andstore-publishrun only on tags; the version check compares csproj and manifest against each other when there is no tag.Verification
actionlintpasses.store-publishjob.After merge
Re-point
v0.1.4at the newmaster(the tag ruleset blocks deletion; disable it briefly).