Skip to content

npm v12 dropped support for the --msvs_version option #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cclauss wants to merge 4 commits into
base: master
Choose a base branch
from
Open

npm v12 dropped support for the --msvs_version option #1000

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bb61e9
npm v12 dropped support for the `--msvs_version` option
cclauss Sep 17, 2026
2077d77
Merge branch 'master' into npm_v12_dropped_--msvs_version
cclauss Sep 17, 2026
b8ca42b
Remove commented code for msvs_version option
cclauss Sep 17, 2026
3767482
Fix comments for clarity and consistency
cclauss Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions test/run.util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ function run(prog, command, args, app, opts, cb) {
// here we add the program and the command
let final_cmd = prog + ' ' + command;

// if we are calling out to `node-pre-gyp` let's ensure we directly
// call the local version at a relative path (to avoid the change) we might
// use some external version on PATH
// if we are calling out to `node-pre-gyp`, let's ensure we directly
// call the local version at a relative path (to avoid the change)
// we might use some external version on PATH
if (final_cmd.indexOf('node-pre-gyp') > -1) {
final_cmd = cmd_path + final_cmd;
if (opts.npg_debug) {
Expand All @@ -53,22 +53,17 @@ function run(prog, command, args, app, opts, cb) {
}
}

// unless explicitly provided, lets execute the command inside the app specific directory
// unless explicitly provided, let's execute the command inside the app-specific directory
if (!opts.cwd) {
opts.cwd = path.join(__dirname, app.name);
}

// Test building with msvs 2022
if (process.platform === 'win32') {
final_cmd += ' --msvs_version=2022 ';
}

// finish appending all arguments
final_cmd += ' ' + app.args;
final_cmd += ' ' + args;


// On unix we want to display compile args (rather than have them hidden)
// On Unix we want to display compile args (rather than have them hidden)
// for easier debugging of unexpected compile failures.
// We do this by pre-pending the magic variable that make responds to.
if (process.platform !== 'win32') {
Expand Down
Loading