Skip to content

fix: revert "Bump nopt from 8.0.0 to 9.0.0 (#919)" - #925

Merged
benmccann merged 1 commit into
mapbox:masterfrom
serhalp:master
Nov 26, 2025
Merged

benmccann merged 1 commit into
mapbox:masterfrom
serhalp:master

Conversation

@serhalp

@serhalp serhalp commented Nov 26, 2025 •

Copy link
Copy Markdown
Contributor

This reverts commit c842373.

Fixes #924.

@benmccann benmccann left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for missing this in #919

@benmccann

Copy link
Copy Markdown
Collaborator

@cclauss we should probably try to get this out quickly as a hot fix. I could merge it, but would need someone to cut the release

@cclauss

cclauss commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

Agreed. Who cut the last release?

@benmccann

Copy link
Copy Markdown
Collaborator

@ductoanthanh did you cut a release by chance? We might need your help cutting another one with this change in it

@rafaykh90

Copy link
Copy Markdown
Contributor

@benmccann I cut the last release. My change in #923 was not supposed to be a breaking change therefore I didn't make a major version change. The breaking change was introduced in one of the earliers PRs which was merged.

As for the change in this PR, do you think the version should be bumped to 2.0.3? I am not sure if it is even allowed on the registry to unpublish a package.

@benmccann

Copy link
Copy Markdown
Collaborator

Yeah, #923 wasn't breaking and you didn't do anything wrong. It was my fault for missing it in #919

We don't need to unpublish the last release. Just merging this and cutting a 2.0.3 would be perfect

@rafaykh90

Copy link
Copy Markdown
Contributor

@benmccann Let's merge this one then. What's the latest you need a new release to be published?

@benmccann
benmccann merged commit 0f21f19 into mapbox:master Nov 26, 2025
20 checks passed
@benmccann

Copy link
Copy Markdown
Collaborator

Merged. Whenever you get a chance for the release would be great. Thanks!

@serhalp

serhalp commented Nov 26, 2025

Copy link
Copy Markdown
Contributor Author

Looks like this was just released as 2.0.3. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.0.2 introduced a breaking change in a patch: now requires node@^20.17.0 || >=22.9.0

4 participants