For Peer Review #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the login module * Added auth service * Added login link to navbar
* Trying to solve Travis CI build errors
* Change title * Add repo to package.json
* Added basic tests - Getting the hang of testing * Moved localStorage manipulation out of auth service
* Added bootsrap through npm * Added jquery through npm * Added theme css * Added Fontawesome
* Jquery is loaded through npm
* Much better strategy as it will take care of any updates to file
* Installed coveralls via npm
* Removed nav bar from both * Made validation errors more helpful * Formatted validation errors better - for visibility
* Builds shouldn't fail anymore
* Implement auth guard on home route
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=========================================
Coverage ? 91.11%
=========================================
Files ? 8
Lines ? 45
Branches ? 2
=========================================
Hits ? 41
Misses ? 4
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.