Skip to content

Project nav-marker-rules will typically not be used on activation #20

Open

Description

@johnarwe

Once the initial display issue described by #19 is fixed, another problem will become apparent: currently nav-view and nav-parser each refer to the other, but nav-parser may be incompletely initialized at the point when nav-view would build the panel (even if nav-view doing so for an already-open file was triggered using a atom.workspace.observeTextEditors event... I've tested it). Nav-parser's constructor calls getProjectRules, but that requires I/O when project-level rules file(s) are present; the I/O will always be asynch, and may (in the general, and already tested, cases) finish after events like observeTextEditors have fired. In order to truly fix the race, any existing panels must be removed (and the active one rebuilt) when the I/Os complete.

I am building a pull request to split nav-parser's initialization (for clarity mostly), and to destroy/rebuild all the panels whenever a project rules file read operation completes. I've tested the flow and it does fix the problem, but separating the code for each of the problems into distinct pull requests will require a bit more time.

Activity

  1. added a commit that references this issue on Jul 28, 2017
    a03f2c8
  2. johnarwe commented on Aug 1, 2017

    @johnarwe
    Author

    @0tho , I see you merged the pull request #23 into the development branch.

    1. What's the issue process, leave the issue open until it merges into master?
    2. Do you have any sense for when you expect to merge it into master?

    Until it merges into master, I think no one using atom.io to get it will see the bug fixes in here and in #19 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions