Integrate Trivy Security Scanning and Fix CVE-2025-24813#5
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
Integrate Trivy Security Scanning and Fix CVE-2025-24813#5devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
- Add Trivy security scanning job to GitHub Actions workflow - Override Tomcat version to 9.0.99 to fix CRITICAL CVE-2025-24813 (Potential RCE and/or information disclosure vulnerability) - Trivy scan results are uploaded to GitHub Security tab as SARIF Co-Authored-By: Marcel Schwager <marcel.schwager@codeium.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Update actions/checkout from v2 to v4 - Update actions/setup-java from v2 to v4 - Update actions/cache from v2 to v4 - Update github/codeql-action/upload-sarif from v2 to v3 Fixes CI failure due to deprecated actions/cache v2 Co-Authored-By: Marcel Schwager <marcel.schwager@codeium.com>
Tomcat 9.0.99 requires --add-opens=java.base/java.io=ALL-UNNAMED when running on Java 17+ due to module access restrictions. Co-Authored-By: Marcel Schwager <marcel.schwager@codeium.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates Trivy security scanning into the CI/CD pipeline and fixes the highest severity vulnerability found in the dependency scan.
Vulnerability Fixed: CVE-2025-24813 (CRITICAL) - Potential RCE and/or information disclosure vulnerability in Apache Tomcat. Fixed by upgrading embedded Tomcat from 9.0.56 to 9.0.99.
Trivy Integration: Added a new
security-scanjob to the GitHub Actions workflow that:The initial scan found 93 total vulnerabilities (11 CRITICAL, 42 HIGH, 33 MEDIUM, 7 LOW). This PR addresses the highest severity one.
Updates Since Last Revision
actions/checkout,actions/setup-java, andactions/cachefrom v2 to v4 (v2 is now deprecated and was causing CI failures)codeql-action/upload-sarifto v3--add-opens=java.base/java.io=ALL-UNNAMEDwhen running on Java 17+ due to module access restrictions. This is configured for thebootRunGradle task.Review & Testing Checklist for Human
--add-opens=java.base/java.io=ALL-UNNAMEDJVM flag is only configured forbootRun. If deploying to production on Java 17+, this flag must be added to your startup script orJAVA_TOOL_OPTIONS@master- consider pinning to a specific version for stabilityexit-code: '0'so it won't block builds on vulnerabilities. Decide if this should be changed to fail on CRITICAL/HIGH findingsRecommended test plan:
./gradlew bootRunlocally (works on both Java 11 and Java 17 with the JVM args fix)/usersendpoint/tagsendpoint returns valid JSONNotes
--add-opensflag is specifically for Java 17+ local developmentLink to Devin run: https://app.devin.ai/sessions/c7b1401cf3ad4d679b07fa901b19478b
Requested by: Marcel Schwager (marcel.schwager@codeium.com) / @marcelschwager-ux