Repository navigation
feat(perf): size the Preferences memory limits to the machine - #1598
Merged
marcinz606 merged 1 commit intoNov 5, 2026
Merged
Conversation
jondestoppeleire
force-pushed
the
feat/hardware-memory-budgets
branch
4 times, most recently
from
November 4, 2026 17:19
a671339 to
81e40ff
Compare
jondestoppeleire
force-pushed
the
feat/hardware-memory-budgets
branch
3 times, most recently
from
November 4, 2026 18:02
58d4e3e to
0875bdf
Compare
The memory limits in Preferences are fixed numbers. An 8 GB machine can set a 32 GB cache with no warning, and a 128 GB machine stops at a 32 GB cache and 16 HQ buffers. Each cache row now shows a recommendation of half of the machine's RAM, or how many entries of that row's size fit in that half. The user can go past it, and the hint then turns amber. A row stops at its old limit or all of RAM, whichever is larger. GPU texture cap goes to 65536 px, past the long edge of a 400 MP frame, with no recommendation. Default values and the default HQ cap do not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jondestoppeleire
force-pushed
the
feat/hardware-memory-budgets
branch
from
November 5, 2026 04:11
0875bdf to
6a5495f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The memory limits in Preferences are fixed numbers. They do not protect small machines, and they hold back large ones. An 8 GB machine can set a 32 GB cache with no warning. A 128 GB machine stops at a 32 GB cache and 16 HQ buffers. GPU texture cap stops at 16384 px, under the long edge of a 400 MP frame.
Change
Each cache row now shows a recommendation from the machine's RAM. The user can go past it, and the hint then turns amber with a warning icon. GPU texture cap goes higher and has no recommendation. Default values and the default HQ cap do not change, and no row has a lower limit than before.
Recommended value, with a 61 MP frame open at the default preview size:
Why this shape
A recommendation is half of RAM, or how many entries of that row's size fit in that half, so it needs no GPU types or machine tiers. A user who goes past a recommendation can run out of memory, and the amber hint is the only protection.
Testing
CI failures not from this PR
tests/test_i18n.py::test_catalog_covers_every_marked_message_and_preserves_formats[vi]also fails onmainate22f98e4.vi.jsonlacks 39 strings from the roll work onmain, and none of them come from this PR. It is the only failure in this job, and this job goes green whenmainhas those strings and this PR is rebased.main, so it needs a re-run. A re-run needs admin rights on this repository.🤖 Generated with Claude Code