Test for mod_rewrite even when PHP is run as CGI #7
Open
dliessi wants to merge 2 commits intomarciuz:masterfrom
Open
Test for mod_rewrite even when PHP is run as CGI #7dliessi wants to merge 2 commits intomarciuz:masterfrom
dliessi wants to merge 2 commits intomarciuz:masterfrom
Conversation
marciuz
approved these changes
May 10, 2020
Owner
|
Hi Davide, indeed, I world like to merge only the first commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit fixes a bug in current
admin/vfront.info.php, whereapache_get_modules()is used without checking if it is available.The second commit adds a test for the availability of
mod_rewritethat seems to work even if PHP is run as CGI, since it directly tests ifmod_rewriteis working.I didn't squash them because you may judge that you are interested only in the first one.