Repository navigation
Sync watcher compression level after manual queue runs - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Max()detection with a proper dominant-mode helper for folders whose target is not yet knownRoot cause
WOFCompressionAlgorithmstores Windows' native API identifiers, not a strength ranking: LZX is1, XPRESS8K is2, and XPRESS16K is3. The watcher usedMax()over detected file algorithms, so any remaining XPRESS16K file caused the folder to be recorded as X16 even after an LZX run.Mixed algorithms are normal because the compressor deliberately skips files that are already on the target mode, are no larger than a cluster, or match excluded-file rules. The watcher's
CompressionLevelis also the target passed into future background recompression, so the stale X16 value affected behavior rather than only the badge.Validation
TreatWarningsAsErrors=trueRuntime test plan