fix: repair profile loading & timeline days; drop sourdough & homebrew - #20
Merged
Merged
Conversation
Profiles (pizza-cli): - Fix --profile, which always crashed: the default snapshot via Args::parse_from failed because --w is required. Fields are now Option<T>, so --w can come from a profile and CLI/profile/default precedence is resolved with Option::or instead of comparing against defaults (an explicit value equal to the default now wins). - Fix --yeast override: an explicit choice now beats the profile in both directions (e.g. --yeast dry over a fresh profile). - Save the profile once, after validation, so invalid configs are no longer written to disk. Re-validate values that arrive via a profile. Timeline (pizza-cli): - Mark phase end times that cross midnight with (+Nd) so long fridge plans aren't misread. Core (pizza-core): - Make test_yeast_percent_bounds actually assert (it discarded the bool) and add a clamp-extremes test. - Remove the never-implemented sourdough remnants (starter_total_g field, misleading docs, single-arm match). CI/docs: - Delete the Homebrew formula template and tap job (placeholders and asset names never matched, so it was broken). - Rewrite the README in a human voice; fix the Rust version (1.85 for edition 2024), the clone directory, and the profile examples. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosa
Review critica del progetto → fix dei bug confermati + pulizia.
Profili (
pizza-cli)--profileera completamente rotto: lo snapshot dei default viaArgs::parse_fromfalliva perché--wè obbligatorio, quindi caricare un profilo usciva sempre con errore. Ora i campi sonoOption<T>,--wpuò arrivare dal profilo e la precedenza CLI > profilo > default è risolta conOption::orinvece che confrontando col default (un valore esplicito uguale al default ora vince).--yeast: la scelta esplicita ora batte il profilo in entrambe le direzioni (es.--yeast drysu un profilofresh).Timeline (
pizza-cli)(+Nd), così i piani con frigo lunghi non si leggono male.Core (
pizza-core)test_yeast_percent_boundsora asserisce davvero (prima scartava ilbool); aggiunto un test sui limiti del clamp.starter_total_g, doc fuorvianti, match a un solo braccio).CI / docs
homebrew_tap(placeholder e nomi degli asset non combaciavano: era rotto).Verifica
cargo clippy --workspace --all-targets -- -D warningspulitocargo test --workspace→ 6/6 verdi🤖 Generated with Claude Code