Skip to content

Allow nullable transaction descriptions - #4

Merged
marcomc merged 1 commit into
release/0.3.0from
feat/nullable-transaction-descriptions
Sep 13, 2026
Merged

marcomc merged 1 commit into
release/0.3.0from
feat/nullable-transaction-descriptions

Conversation

@marcomc

@marcomc marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve Core Data ZDESC2 = NULL as an optional transaction description
  • continue rejecting binary, numeric, boolean, and string-subclass persisted values
  • cover direct model validation and complete synthetic SQLite reads

Validation

  • focused nullable-description tests: 11 passed
  • full unit suites: 805 passed, 1 skipped on Python 3.10 and 3.11
  • independent review: 68 focused tests plus nullable/invalid-shape and real SQLite completeness probes
  • Ruff and diff checks passed

This is a fork-only P0 read-model correction. It contains no write capability or MoneyWiz Tools-specific behavior.

Preserve Core Data NULL descriptions as optional text while rejecting malformed persisted description shapes.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T14:13:36.526575Z 3f74a22 Manual request
🔒 Security Review ✅ Completed 2026-09-13T14:14:24.548861Z 3f74a22 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 3f74a22f32

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marcomc
marcomc merged commit 7cfa1ea into release/0.3.0 Sep 13, 2026
2 checks passed
@marcomc
marcomc deleted the feat/nullable-transaction-descriptions branch September 26, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant