Skip to content

[codex] 0.3.0: reconciliation reads and runtime identity - #3

Merged
marcomc merged 10 commits into
release/0.3.0from
feat/p0-read-foundation
Sep 13, 2026
Merged

marcomc merged 10 commits into
release/0.3.0from
feat/p0-read-foundation

Conversation

@marcomc

@marcomc marcomc commented Sep 13, 2026 •

Copy link
Copy Markdown
Owner

MoneyWiz Tools 0.3.0 — P0 read foundation

Summary

Implements the read foundation for release 0.3.0: reliable reconciliation
snapshots, explicit completeness diagnostics and exact runtime identity.
Malformed or unsupported rows must not silently appear to be a complete read,
and later write planning must be able to bind an unambiguous app/store/model.

  • Add read-only runtime identity discovery for app edition/build, store UUID,
    local owner and Core Data model checksum.
  • Add reconciliation snapshots with relationship/transfer audits and explicit
    timezone-aware cutoff semantics. Audits are observations, not authorization.
  • Admit reciprocal transfer pairs before pair-state audits and report each pair
    once. Refuse malformed cached balances and nonfinite financial output.
  • Expose optional completeness diagnostics for accounts, transactions and
    holdings. Partial reads return 3; bounded command failures return 2.
  • Preserve accountless budget rows and parsed accounts whose owner row is
    missing; keep diagnostics safe for malformed binary/date values.
  • Pin the independently reviewed API read implementation into the lockfile and
    self-contained bundle. Include every new runtime module and remove private
    build-checkout paths from generated requirements and native diagnostics.
  • Align 0.3.0 metadata, documentation, progressive tasks and release-branch
    review workflow. Future implementation branches use visible owner tasks.

Dependency and scope

Depends on moneywiz-api PR #2,
pinning reviewed commit cd1f8b5b81426ea7bb1f05fefcc9501453390d7c.
The source pin, lockfile, installed distribution and bundled API file hashes agree.
Dependency integration remains gated on that PR's CI and release-branch merge.

This PR targets release/0.3.0, not main. It implements P0 only; the shared
writer foundation and W01–W04 remain subsequent release work. No new write
capability is enabled. Existing v1 payee reassignment safety remains covered.

Validation

  • Final pinned CLI/native-ownership suite: 269 passed; three installed opt-in
    tests skipped in that run and then executed separately, all three passing.
  • Synthetic shell examples pass.
  • Bundle publication suite: 17 passed, including negative build-path checks.
    Removing either build-path fix causes the intended regression to fail.
  • Focused read-boundary suite: 94 passed. Seven removed-fix mutations each fail
    their regression, covering pair admission/cardinality and numeric output.
  • Fresh isolated bundle builds and runs independently of the source checkout.
    Verified bundled interpreter/import locations, exact dependency provenance,
    payload hashes and absence of private checkout/user paths in the artifact.
  • Installed complete/partial/error reads, malformed numeric refusals,
    receiving-only pair audits and native model-checksum routes pass.
  • Ruff check/format, Python compilation, shellcheck with all checks enabled,
    Bash syntax, Markdownlint, plist validation and whitespace checks pass.

The project tests use Python 3.11.13; the isolated bundle contains Python 3.11.16.
The dependency separately passed 776 tests with one opt-in skip on each supported
Python 3.10/3.11 runtime and received an exact-head clean Codex review.

All database fixtures were synthetic. No production account changes, application
reconciliation, remote sync acceptance or replacement of the user's installed
bundle is claimed by this PR. Those remain separate operation-specific gates.

Deliver explicit read completeness, graph snapshots and app/store/model discovery; pin the independently reviewed API into the self-contained 0.3.0 bundle. Add installed-runtime and package-privacy regressions, align documentation and release workflow, and preserve capability-gated writes.
@marcomc
marcomc marked this pull request as ready for review September 13, 2026 09:35
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-13T16:26:08.836279Z b42d441 Manual request
🔒 Security Review ✅ Completed 2026-09-13T09:39:27.432756Z fb1ee20 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb1ee20d9b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/snapshot.py
Comment thread scripts/snapshot.py
Comment thread scripts/snapshot.py Outdated
Gate pair observations on reciprocal transaction/account links and emit each valid pair once. Reuse finite Decimal output validation for transactions, categories and holdings, and reject malformed native cached balances. Add synthetic and installed regression coverage with mutation-sensitive controls.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41bfbe74f1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/read_support.py
Comment thread scripts/read_support.py
Comment thread scripts/snapshot.py
Comment thread scripts/read_support.py
Comment thread scripts/snapshot.py
Comment thread doc/RECONCILIATION-READS.md Outdated
Reject non-finite read values, distinguish unreadable transfer counterparts, retain bounded date safety, and pin the reviewed MoneyWiz API remediation in distributable bundles.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Consume the reviewed API descendant-discovery remediation and record its exact tested revision in dependency metadata and release documentation.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f871b0fdc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/snapshot.py
Comment thread scripts/runtime_identity.py Outdated
Comment thread scripts/transactions.py Outdated
Comment thread scripts/snapshot.py Outdated
Validate native identity, description and status fields and audit reciprocal transfers for exact fee-adjusted FX consistency.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d6bf4e29e7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/snapshot.py
Comment thread scripts/snapshot.py Outdated
Audit transfer fee currency compatibility and return partial diagnostics for selected unreadable accounts.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c653f127b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/read_support.py
Comment thread moneywiz.sh Outdated
Consume the nullable-description API revision and align dispatcher errors, diagnostics, tests, bundles, and P0 evidence.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Provided git ref 0471d2615307f58c4f629c18593602299f1691bc does not exist
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0471d26153

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/reassign_payees_by_id.py
Comment thread scripts/holdings.py Outdated
Retain the established Setapp default for payee reassignment while preserving explicit runtime overrides. Validate selected holdings accounts so absent, unreadable, and valid-empty states produce the correct completeness result and exit status.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7b20068500

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/transactions.py
Comment thread scripts/runtime_identity.py
Comment thread scripts/snapshot.py Outdated
Comment thread scripts/snapshot.py Outdated
Comment thread scripts/transactions.py Outdated
Validate selected account identity consistently, reject duplicate owner IDs and malformed archived scalars, distinguish unreadable graph references, and aggregate partial diagnostics into one coherent document. Add source and installed-bundle regressions plus contract documentation.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4c7eba6c38

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/runtime_identity.py Outdated
Comment thread scripts/runtime_identity.py Outdated
Validate complete non-empty owner sets before binding, detect physical store ambiguity independently of store-local owner selection, and keep explicit store and owner resolution ordered. Add mutation-sensitive discovery and malformed-owner regressions.
@marcomc

marcomc commented Sep 13, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: b42d4418d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@marcomc
marcomc merged commit 374ebd4 into release/0.3.0 Sep 13, 2026
@marcomc
marcomc deleted the feat/p0-read-foundation branch September 26, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant