Enhance testing infrastructure and optimize CI workflows - #18
Closed
marcomoi395 wants to merge 7 commits into
Closed
Enhance testing infrastructure and optimize CI workflows#18marcomoi395 wants to merge 7 commits into
marcomoi395 wants to merge 7 commits into
Conversation
- Add Vitest testing infrastructure (vitest.config.ts, test/setup.ts) - Write unit and integration tests across 4 phases (Core, Services, Handlers, Renderer) - Migrate notion-sync tests from node:test to vitest - Fix minor bugs in validators.ts and pexels.ts discovered during testing - Add ignore branches for defensively unreachable code - Achieve overall coverage above 95% threshold across Statements, Branches, Functions, and Lines
- Remove auto-release feature (release-please workflow) - Add comprehensive CI workflow with quality gates: - Lockfile registry validation (PR only) - Dependency vulnerability review (PR only) - Lint, typecheck, unit tests, E2E tests - SHA-pinned actions with explicit permissions - Add tag-triggered build-and-release workflow: - Creates draft releases on v* tags - Builds Linux (AppImage, deb) and Windows (NSIS) packages - Uploads assets to GitHub releases - Update release-smoke workflow: - Inline matrix builds for manual testing - Remove dependency on deleted reusable workflow - Apply security standards (SHA pinning, timeouts) - Delete obsolete workflows: - release-please.yml - build-release.yml - reusable-build-assets.yml - e2e-tests.yml (integrated into ci.yml) - Update architecture documentation
Job will now continue even if Dependency graph is not enabled in repo settings
Project uses npm with package-lock.json as the source of truth. yarn.lock was outdated and causing false security warnings in CI (tar@7.5.7 vulnerabilities that don't exist in package-lock.json).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.