Skip to content

Herb: Upgrade Prism to v2.0.0 and rubydex to v0.4.3 - #2855

Open
marcoroth wants to merge 1 commit into
mainfrom
upgrade-prism-v2.0.0
Open

Herb: Upgrade Prism to v2.0.0 and rubydex to v0.4.3#2855
marcoroth wants to merge 1 commit into
mainfrom
upgrade-prism-v2.0.0

Conversation

@marcoroth

@marcoroth marcoroth commented Oct 26, 2026

Copy link
Copy Markdown
Owner

No description provided.

@github-actions github-actions Bot added linter @herb-tools/linter for HTML+ERB templates formatter @herb-tools/formatter for HTML+ERB templates ruby Ruby source for the gem and its libraries javascript JavaScript source across the javascript/ packages wasm WebAssembly build and bindings typescript TypeScript source across the javascript/ packages c C source for the core parser, lexer, and AST node @herb-tools/node native Node.js addon node-wasm @herb-tools/node-wasm WebAssembly parser for Node.js c-extension Ruby C extension in ext/ sorbet Sorbet type signatures and sorbet/ configuration rust Rust bindings and the Herb Rust crate java Java bindings and the org.herb package core @herb-tools/core shared AST nodes, interfaces, and utilities cpp C++ source, primarily the WebAssembly bindings rewriter @herb-tools/rewriter AST and string transformation system browser @herb-tools/browser WebAssembly parser for browsers action-view-helpers Action View helper support and metadata labels Oct 26, 2026
@github-actions

github-actions Bot commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Corpus: this branch (8c84980) vs main (fc3ca23)

main (fc3ca23) this branch (8c84980)
Malformed templates 229 229 –
Parse issues (all) 1057 1058 +1
Compile issues 513 513 –
Files with line drift 68 68 –
Tags off their line 476 476 –
Clean files 38717 38716 -1

Measured over 40318 templates from herb-corpus.

5 diagnostics changed count
Diagnostic main (fc3ca23) this branch (8c84980)
RubyParseError 72 78 +6
MissingERBEndTagError 23 21 -2
ERBControlFlowScopeError 118 119 +1
MissingClosingTagError 654 653 -1
MissingOpeningTagError 635 634 -1

A count can drop because a false positive was fixed, or because a diagnostic is no longer reported when it should be. Worth confirming which.

1 file no longer parses
File Error
openproject/modules/documents/app/components/documents/show_edit_view/page_header/live_users_component.html.erb analyze_parse_error, RubyParseError ×6, ERBControlFlowScopeError

@marcoroth
marcoroth force-pushed the upgrade-prism-v2.0.0 branch from cb78ba3 to 7ecdd6a Compare October 26, 2026 19:41

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

action-view-helpers Action View helper support and metadata browser @herb-tools/browser WebAssembly parser for browsers c C source for the core parser, lexer, and AST c-extension Ruby C extension in ext/ core @herb-tools/core shared AST nodes, interfaces, and utilities cpp C++ source, primarily the WebAssembly bindings formatter @herb-tools/formatter for HTML+ERB templates java Java bindings and the org.herb package javascript JavaScript source across the javascript/ packages linter @herb-tools/linter for HTML+ERB templates node @herb-tools/node native Node.js addon node-wasm @herb-tools/node-wasm WebAssembly parser for Node.js rewriter @herb-tools/rewriter AST and string transformation system ruby Ruby source for the gem and its libraries rust Rust bindings and the Herb Rust crate sorbet Sorbet type signatures and sorbet/ configuration typescript TypeScript source across the javascript/ packages wasm WebAssembly build and bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marcoroth