This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Make Box's "fill" behavior optional#105
Open
cceckman wants to merge 4 commits into
Open
Conversation
This reverts commit 171ef32. It has some calls to methods that don't yet exist- making Box's fill behavior optional. This allows it to be used for layout as well as styling.
This was referenced Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#89 enforces that
Boxfills in its background. This is nice because it means we can get a large area with consistent coloring, e.g. a status bar or title bar.With #46 (modal dialogs), we may need some way or ways to do layouts on top of other widgets- with some transparency in those widgets.
This makes
Box's fill-the-background behavior subject to the value set inSetFill, similar to how the border is handled.