Repository navigation
perf: use nonvirtual JNI calls for known Kotlin implementations - #1814
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
marked this pull request as draft
October 20, 2026 15:42
mrousavy
force-pushed
the
mrousavy/v1-android-dispatch
branch
from
October 20, 2026 22:05
0083daf to
b636f61
Compare
mrousavy
changed the title
mrousavy
marked this pull request as ready for review
October 20, 2026 22:06
mrousavy
force-pushed
the
mrousavy/v1-android-dispatch
branch
from
October 20, 2026 22:07
b636f61 to
9f84a2c
Compare
mrousavy
force-pushed
the
mrousavy/v1-android-dispatch
branch
from
October 20, 2026 22:39
9f84a2c to
6efaeec
Compare
mrousavy
force-pushed
the
mrousavy/v1-android-dispatch
branch
from
October 20, 2026 23:06
6efaeec to
f8e7acb
Compare
mrousavy
force-pushed
the
mrousavy/v1-android-dispatch
branch
from
October 21, 2026 11:34
87e047e to
18e4613
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses fbjni nonvirtual calls for direct instance members when a Kotlin implementation is known and both inheritance and multiple implementations are disabled. Private conversion bridges also use nonvirtual calls.
KotlinHybridObjectTypeowns the eligibility getter for nonvirtual calls, used by both Kotlin and C++ generation. Every generatedCxxPartexposes a staticgetClass(): eligible implementations use a kept Kotlin@JvmFieldclass literal and a cached global JNI reference; other specs return their generated Java class. All instance member lookups use this accessor, including private conversion bridges.Includes regenerated standalone and React Native specs.
Validation: Nitrogen generation, typecheck, ESLint, and formatting checks; generated Kotlin compilation and native C++ checks for arm64, armv7, and x86_64; host JVM and Android ART dispatch probes with
-Xcheck:jni, covering inheritance, alternate implementations, and private conversion bridges. The getter and naming refactor leaves all 757 generated files byte-identical.