Repository navigation
Conversation
Add SwiftResultConsumer and receiveSwiftResult(). Swift lends a successful value to the consumer, which copies it straight into Result<T>, so the value does not have to come back to C++ in a boxed swift::Optional<T>. Generated Swift code receives the consumer as a raw pointer until our minimum Xcode includes swiftlang/swift#93321 (fixes swiftlang/swift#93318).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
SwiftResultConsumerandreceiveSwiftResult<T>()to Core. #1992 switches generated Swift methods over to them.Throwing Swift methods that return a Swift value, such as a string, array or struct, go through
withSwiftResult()today. It callstryMakeSwiftValue<T>(), which returnsT?, and C++ allocates a box for thatswift::Optional<T>on every successful call.receiveSwiftResult()passes a consumer to the Swift call instead. Swift calls it while it still owns the value, and C++ copies the value straight intoResult<T>. Swift errors still come back through theResult<void>status. If the copy throws, the consumer stores the exception in the Result, since it runs inside a Swift frame.Generated Swift code gets the consumer as an
UnsafeRawPointer, because naming the C++ record in exported Swift signatures hits swiftlang/swift#93318. The TODO points at the fix, swiftlang/swift#93321.withSwiftResult()stays because the Swift callback adapters still use it.The standalone iOS suite passes on this branch by itself.
🤖 Generated with Claude Code