Repository navigation
Conversation
JSI lets a JS engine destroy a native function's state on any thread. Hermes' concurrent GC does that on its own background thread, which is not attached to the JVM on Android. The test runtime now has `destroyOnBackgroundThread(fn)`, which takes a native function's state and destroys it on a new thread. Two cases use it on the `then` and `catch` listeners Nitro adds to a JS Promise passed to `awaitAndGetPromise(...)`, once while pending and once after it resolved. Kotlin crashes on both: the listeners release JNI global references and reject the Kotlin Promise without an attached thread.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mrousavy
added this pull request to stack #1995
October 23, 2026 12:14
mrousavy
removed this pull request from stack #1995
October 23, 2026 12:14
mrousavy
added this pull request to stack #1996
October 23, 2026 12:14
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSI lets a JS engine destroy a native function's state on any thread. Hermes' concurrent GC does that on its own thread, which the JVM never attached on Android.
The test runtime gets
destroyOnBackgroundThread(fn). It takes the native state out of a native JS function and destroys it on a new thread. TwoMemorycases use it on thethenandcatchlisteners Nitro adds to a JS Promise passed toawaitAndGetPromise(...): once while the Promise is pending, and once after it resolved.C++ and Swift pass. Kotlin crashes with
Unable to retrieve jni environment. Is the thread attached?, thrown fromGlobalReferenceAllocator::deleteReferencewhile the listeners release the Kotlin result. Android CI stays red until the PR on top of this one.Callbacks aren't covered. A Kotlin callback returned to JS is also owned by its Java
Callback_*_cxxobject, so which owner releases it last depends on Java GC.🤖 Generated with Claude Code