Skip to content

perf(android): pass Kotlin callbacks through JNI as Callback - #2009

Open
mrousavy wants to merge 1 commit into
mrousavy/v1-kotlin-ulongarrayfrom
mrousavy/v1-kotlin-callback-jni
Open

mrousavy wants to merge 1 commit into
mrousavy/v1-kotlin-ulongarrayfrom
mrousavy/v1-kotlin-callback-jni

Conversation

@mrousavy

@mrousavy mrousavy commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Pass callbacks through JNI as Nitro's existing Kotlin Callback interface. JTypedCallback retains signature information in C++ without adding a Java wrapper.

This removes Kotlin callback conversion bridges and the array, map, and Promise conversions they required. Existing native callbacks reuse their C++ callback; Kotlin callbacks get an adapter when C++ needs to call them.

Third in the stack: #2017 → #1997 → #2009.

Validated Kotlin compilation, Nitrogen output, TypeScript checks, and all generated Android JNI translation units, including React Native views.

@mrousavy
mrousavy added this pull request to stack #2000 October 23, 2026 18:13
@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
nitro-docs Skipped Skipped Oct 28, 2026 11:22am UTC

Request Review

@mrousavy
mrousavy removed this pull request from stack #2000 October 28, 2026 11:22
@mrousavy
mrousavy force-pushed the mrousavy/v1-kotlin-callback-jni branch from bbeb5f0 to 77be1d4 Compare October 28, 2026 11:22
@mrousavy
mrousavy changed the base branch from mrousavy/v1-kotlin-nested-ulongarray to mrousavy/v1-kotlin-ulongarray October 28, 2026 11:24
@mrousavy
mrousavy added this pull request to stack #2018 October 28, 2026 11:24

This branch was previously deployed

1 inactive deployment
Preview — 77be1d42 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant