Repository navigation
fix(swift): avoid duplicate callback metadata in struct bridges - #2013
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
hannojg
marked this pull request as ready for review
October 27, 2026 14:36
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two modules exposing the same callback signature in struct fields emit duplicate Swift metadata and fail to compile together. Repro:
Struct initializers and getters now use typed C++ value wrappers owned by each module. This gives Swift distinct types to export and avoids duplicate metadata for the shared callback and Promise specializations.
This works around swiftlang/swift#93318. Remove the wrappers once the minimum supported Xcode includes swiftlang/swift#93321.