Skip to content

fix: default dark mode cleanup every page - #6

Merged
sabraman merged 1 commit into
mainfrom
dark-mode-every-page-default
May 16, 2026
Merged

fix: default dark mode cleanup every page#6
sabraman merged 1 commit into
mainfrom
dark-mode-every-page-default

Conversation

@sabraman

@sabraman sabraman commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary\n- bump Dark Mode example package to 0.1.6\n- default reader cleanup to every page for reduced inverted text ghosting\n- update release archive docs\n\n## Validation\n- python3 ../marginalia-sdk/tools/validate_manifest.py --profile publish */manifest.json\n- python3 ../marginalia-sdk/tools/build_package.py dark-mode-theme --output dist\n- CodeRabbit CLI

Summary by CodeRabbit

  • New Features

    • Reader cleanup now automatically runs on every page by default, reducing dark-mode text ghosting without harsh refresh flashes.
  • Documentation

    • Updated documentation to reflect new default behavior and v0.1.6 release availability.

Review Change Stack

@blacksmith-sh

blacksmith-sh Bot commented May 16, 2026

Copy link
Copy Markdown

Blacksmith Account Suspended

This Blacksmith account requires additional verification. Jobs targeting Blacksmith runners will not be picked up and will remain queued until they timeout.

Please contact Blacksmith Support for assistance.

@coderabbitai

coderabbitai Bot commented May 16, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8bdcc053-49e4-4624-af66-f9e7e57e4ae0

📥 Commits

Reviewing files that changed from the base of the PR and between 0559886 and 01c6072.

📒 Files selected for processing (3)
  • README.md
  • dark-mode-theme/README.md
  • dark-mode-theme/manifest.json

📝 Walkthrough

Walkthrough

Dark Mode theme is released as v0.1.6 with updated configuration and documentation. The manifest version is bumped, the default readerRefresh behavior changes from 5-pages to every-page, and all README files are updated to document the new version and clarify the default reader cleanup behavior.

Changes

Dark Mode v0.1.6 Release

Layer / File(s) Summary
Manifest version and default behavior update
dark-mode-theme/manifest.json
Theme manifest version bumped to 0.1.6. The readerRefresh setting default changes from 5-pages to every-page to reduce dark-mode text ghosting by running reader cleanup on every page by default.
README and documentation updates
README.md, dark-mode-theme/README.md
Root and package README files are updated to point to v0.1.6 release archive and document that reader cleanup now runs on every page by default to reduce text ghosting.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A version hops from five to six,
Dark mode defaults now get fixed—
Every page, no ghostly text,
Reader cleanup does its best! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating the default dark mode cleanup behavior to run on every page instead of every 5 pages.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dark-mode-every-page-default

Comment @coderabbitai help to get the list of available commands and usage tips.

@sabraman
sabraman merged commit 955156f into main May 16, 2026
2 checks passed
@sabraman
sabraman deleted the dark-mode-every-page-default branch May 16, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant