Addressing issue 89: incorporating SUP on App Registry as OCI Registry by arne-broering · Pull Request #123 · margo/specification

arne-broering · 2025-11-06T11:57:15Z

Description

This PR implements the accepted SUP: App Registry as OCI Registry

Issues Addressed

Issue #89

Change Type

Please select the relevant options:

Fix (change that resolves an issue)
New enhancement (change that adds specification content)
Content edits (change that edits existing content)

Checklist

I have read the CONTRIBUTING document.
My changes adhere to the established patterns, and best practices.

Signed-off-by: Arne Broering <arne.broering@siemens.com>

mkdocs.yml

system-design/concepts/workloads/application-package.md

Signed-off-by: Arne Broering <arne.broering@siemens.com>

src/specification/application-package/resources/index.md.jinja2

system-design/concepts/workloads/application-package.md

system-design/concepts/applications/application-registry.md

system-design/specification/application-package/application-registry.md

Signed-off-by: Arne Broering <arne.broering@siemens.com>

ajcraig

Looks good to me!

Signed-off-by: Arne Broering <arne.broering@siemens.com>

Silvanoc

Partial review. Pending files will follow.

system-design/concepts/applications/application-package.md

Silvanoc

Another partial review.

In general I prefer the term "OCI registry" over "Container Image Registry" (or the extremely extended for space reasons, but incorrect "Container Registry") ‼️

system-design/concepts/applications/application-registry.md

system-design/concepts/applications/local-registries.md

Silvanoc

3rd and before-last review

system-design/overview/applications.md

system-design/overview/envisioned-system-design.md

system-design/personas-and-definitions/technical-lexicon.md

system-design/specification/applications/application-registry.md

Silvanoc

Replacing a previous broken code change suggestion.

system-design/specification/applications/application-registry.md

Signed-off-by: Arne Broering <arne.broering@siemens.com>

… content merged include the following two PRs: 1. margo/specification#124 2. margo/specification#123 Signed-off-by: Armand Craig <ajcraig@ra.rockwell.com>

arne-broering added 12 commits October 31, 2025 14:11

iniital commit to integrate SUP

c552d8d

Signed-off-by: Arne Broering <arne.broering@siemens.com>

integrating SUP decision

6c67ddc

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

54ade4c

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

cf80f39

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

45f1e5c

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

cb08b22

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

8a8ae18

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

ca68501

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

14c73a3

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

3ec997d

Signed-off-by: Arne Broering <arne.broering@siemens.com>

editing formal App Registry spec

189817d

Signed-off-by: Arne Broering <arne.broering@siemens.com>

adjusting rest of spec to latest adjustments on the Application Registry

b0a4aeb

Signed-off-by: Arne Broering <arne.broering@siemens.com>

arne-broering self-assigned this Nov 6, 2025

arne-broering requested a review from a team as a code owner November 6, 2025 11:57

arne-broering marked this pull request as draft November 6, 2025 11:57

This comment was marked as resolved.

Sign in to view

phil-abb reviewed Nov 6, 2025

View reviewed changes

mkdocs.yml Show resolved Hide resolved

mkdocs.yml Show resolved Hide resolved

system-design/concepts/workloads/application-package.md Outdated Show resolved Hide resolved

system-design/concepts/workloads/application-package.md Outdated Show resolved Hide resolved

addressing PR comment about no specification language in concept section

9aecef2

Signed-off-by: Arne Broering <arne.broering@siemens.com>

This comment was marked as resolved.

Sign in to view

phil-abb reviewed Nov 6, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

arne-broering added 5 commits November 7, 2025 15:44

addressing PR review comments

af1b2e5

Signed-off-by: Arne Broering <arne.broering@siemens.com>

addressing PR review comments

59620e5

Signed-off-by: Arne Broering <arne.broering@siemens.com>

renamed the files & folders which were renamed in the nav

58a8563

Signed-off-by: Arne Broering <arne.broering@siemens.com>

renamed the files & folders which were renamed in the nav

5528706

Signed-off-by: Arne Broering <arne.broering@siemens.com>

removed incorrect sentence from technical lexicon

92b2e42

Signed-off-by: Arne Broering <arne.broering@siemens.com>

This comment was marked as resolved.

Sign in to view

ajcraig self-requested a review November 7, 2025 16:07

changed overview figure

171d87b

Signed-off-by: Arne Broering <arne.broering@siemens.com>

This comment was marked as resolved.

Sign in to view

Removed 'Marketplace' term and adjusted 'Application Catalog' term usage

1e57df5

Signed-off-by: Arne Broering <arne.broering@siemens.com>

This comment was marked as resolved.

Sign in to view

arne-broering added 3 commits December 2, 2025 16:21

added note for authentication

1030d8c

Signed-off-by: Arne Broering <arne.broering@siemens.com>

changed application overview

43a53a3

Signed-off-by: Arne Broering <arne.broering@siemens.com>

add digest option

056331a

Signed-off-by: Arne Broering <arne.broering@siemens.com>

arne-broering requested a review from Silvanoc December 3, 2025 07:31

removing folder structure requirement

7033e13

Signed-off-by: Arne Broering <arne.broering@siemens.com>

arne-broering requested review from ajcraig and phil-abb December 3, 2025 11:38

ajcraig approved these changes Dec 3, 2025

View reviewed changes

arne-broering added 2 commits December 3, 2025 14:48

fixing pages error

a632556

Signed-off-by: Arne Broering <arne.broering@siemens.com>

removed link to private GitHub repo

0ae0969

Signed-off-by: Arne Broering <arne.broering@siemens.com>

phil-abb approved these changes Dec 3, 2025

View reviewed changes

Silvanoc reviewed Dec 3, 2025

View reviewed changes

Silvanoc reviewed Dec 4, 2025

View reviewed changes

system-design/specification/applications/application-registry.md Outdated Show resolved Hide resolved

arne-broering added 3 commits December 10, 2025 13:39

addressing various view comments from Sivanoc

631ee9f

Signed-off-by: Arne Broering <arne.broering@siemens.com>

addressing more review comments from Sivanoc

4a9fb04

Signed-off-by: Arne Broering <arne.broering@siemens.com>

final corrections

fee8f41

Signed-off-by: Arne Broering <arne.broering@siemens.com>

arne-broering requested a review from Silvanoc December 10, 2025 14:23

arne-broering marked this pull request as ready for review December 10, 2025 14:26

Silvanoc approved these changes Dec 10, 2025

View reviewed changes

merging

f4dcf3c

Signed-off-by: Arne Broering <arne.broering@siemens.com>

arne-broering merged commit f4dcf3c into pre-draft Dec 10, 2025
10 checks passed

ajcraig mentioned this pull request Dec 10, 2025

Updates to match approved SUP PRs in the specification repository. margo/general_website_content#4

Merged

Conversation

arne-broering commented Nov 6, 2025

Description

Issues Addressed

Change Type

Checklist

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

ajcraig left a comment

Choose a reason for hiding this comment

Uh oh!

Silvanoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Silvanoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Silvanoc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Silvanoc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Silvanoc left a comment •

edited

Loading