Switch away from deprecated GtkShortcutsWindow

[linkmauve]

libadwaita now provides AdwShortcutsDialog, which integrates much better with the rest of the application, has a built-in search entry (well, we only got five shortcuts, but still!), doesn’t popup a different window, and doesn’t require any special code to handle as it is setup by the AdwApplication automatically.

I’ve also added a menu entry to display this dialog, in addition to the <Primary>question shortcut to make it more easily discoverable.

This bumps the minimum libadwaita version from 1.5 to 1.8, I don’t know what’s your policy related to those bumps.

[marin-m]

Hello,

The current target for SongRec is libadwaita 1.5, which is the version available in the Ubuntu 24.04 LTS repositories (https://packages.ubuntu.com/noble/libadwaita-1-0), and Adw.ShortcutsDialog is indeed only available since libadwaita 1.8.

The compatibility is needed because we still push updates for the current Ubuntu LTS through the PPA distribution.

Regards,

[linkmauve]

Hmm, I get deprecation warnings from GtkShortcutsWindow (in addition to all of the things I mentioned above) running on GTK 4.22… Would there be a better solution to maybe support both and pick the best widget at runtime, based on the available library versions?

Although I guess deprecation means nothing as long as we stay on GTK 4.

[marin-m]

Would there be a better solution to maybe support both and pick the best widget at runtime, based on the available library versions?

This would incur some conditional compilation overhead, including having conditions around the loaded resource files, as Gtk.Builder won't accept to load a file containing an unknown widget:

thread 'main' (2606524) panicked at src/gui/main_window.rs:125:14:
called `Result::unwrap()` on an `Err` value: Error { domain: gtk-builder-error-quark, code: 6, message: ".:18:4032 Invalid object type 'AdwInexistingWidgetName'" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Also it would require not to have incompatible symbols linked to the ELF binary

Although I guess deprecation means nothing as long as we stay on GTK 4.

Indeed it's only informative