Custom website search#286
Conversation
…lt on any website. Example usage: website_search_url = "https://music.youtube.com/search?q=" website_search_text = "Search on Youtube Music"
|
Hello! Thank you for implementing this, I'm ok with adding the features, I think that before merging a few things should be done in order to align the code logic over the other settings present in SongRec:
Also I don't know whether it could be useful to parametrize more fields as advised in issue #241 (the track name and the artist name can currently be separated through splitting after the first Please let me know if you wish to make the changes yourself, or if you prefer that I eventually implement these. Regards, |
|
When it comes to the UI, it will likely be a lot less painful for you to eventually implement the changes, since I'm not familiar with GTK. I originally had done the name splitting into {artist} and {title} in order to match the URL posted in #241, but then I found that MusicBrainz allowed the same search using the combined string so it didn't seem worth it. Maybe later, if someone opens an issue mentioning a specific website that won't work unless they get separate tags. |
9306fca to
66b2127
Compare
|
Thanks for your contribution! |
Adds two Preferences for advanced users to choose a custom website for the song search.
Closes #241 with the following settings:
Known issue: I can't figure out how to update the text in the context menu; I've never used GTK before. I'm opening this PR anyway because you may have a quick fix for that. Otherwise, changing the context menu text to something generic might do the trick.