Fix MMCIF topology creation#3
Closed
PardhavMaradani wants to merge 1 commit intomarinegor:feature/mmciffrom
Closed
Fix MMCIF topology creation#3PardhavMaradani wants to merge 1 commit intomarinegor:feature/mmciffrom
PardhavMaradani wants to merge 1 commit intomarinegor:feature/mmciffrom
Conversation
Owner
|
hey! it seems that it actually solves the problem, thank you so much :) I've rebased your changes onto my branch and will close this PR, and move the discussion to the original one while tagging you there -- hope you don't mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @marinegor, I had some experience creating an MDAnalysis converter for converting Biotite
AtomArray/AtomArrayStackto an MDAnalysis universe as part of BradyAJohnston/MolecularNodes#960, so I took a look at MDAnalysis#4712 based on your Discord message. This PR follows the pattern of other converters and passes all the tests intopology/test_mmcif.py. Hope this helps with your PR. Thanks