fix: query block rename bugs - #114
Merged
Merged
Conversation
Jasper-Maris
requested review from
sharppaul
and
a lite review from Copilot
and removed request for
sharppaul
September 8, 2026 13:56
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes address the reported click-order bug and add focused guards without introducing new behavior risks.
Pull request overview
This PR fixes the query block rename flow in the query builder selector. It ensures the rename editor closes after one click, as described in issue #92.
Changes:
- Replace unreliable
autofocuswith a Svelte action that focuses and selects the rename input on mount. - Guard the blur handler so it does not re-commit after the editor already closes.
- Prevent the finish button
mousedownfrom stealing focus, so a blur-commit cannot re-open edit mode.
File summaries
| File | Description |
|---|---|
| src/lib/components/query-builder/QueryBuilderSelectorBlock.svelte | Fix input focus and blur/click ordering, so rename commit closes edit mode on the first click. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sharppaul
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#92