Feature 94 new home page - #116
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It contains a layout bug (Launchpad card max-width) and unresolved case-sensitive import risks across the app.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the Beacon Studio home page for Issue #94 by adding a “How it works” guide and example queries. It also introduces a runtime-loaded examples data source from static/home-examples.json.
Changes:
- Add a persisted “How it works” section and a “Quick start examples” section to the home page.
- Add a
homeExamplesstore plus a loader that fetchesstatic/home-examples.jsonat runtime. - Simplify the home “Launchpad” and remove Map/Chart entries from the visible cards.
File summaries
| File | Description |
|---|---|
| static/home-examples.json | Adds three example query cards as runtime-loaded JSON data. |
| src/routes/+page.svelte | Reworks home page layout into sections and integrates new home components. |
| src/routes/+layout.svelte | Triggers home examples load on app mount. |
| src/lib/data/home-examples.ts | Defines HomeExample schema, store, and JSON loader with validation. |
| src/lib/components/home/QuickStartExamples.svelte | Renders example cards and links into the app using share links. |
| src/lib/components/home/HowItWorks.svelte | Adds a 3-step guide with persisted open/closed state via localStorage. |
Review details
- Files reviewed: 6/12 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
text change to query examples
There was a problem hiding this comment.
🔵 Needs a closer look
The Launchpad grid CSS constrains cards to 32.7% width and can break the single-card layout.
Review details
Suppressed comments (3)
Previously missed (1) — in code that hasn't changed since the last review.
src/lib/data/home-examples.ts:39
- The comment says no build or release is needed after edits to
static/home-examples.json. This app uses@sveltejs/adapter-static, so you must rebuild and redeploy to publish changes.
src/routes/+page.svelte:220
max-width: 32.7%prevents the grid item from stretching to its column. With one Launchpad card, the card stays narrow and leaves empty space.
:global(.card) {
padding: 0;
overflow: hidden;
max-width: 32.7%;
}
src/routes/+layout.svelte:22
loadHomeExamples()runs in the root layout. This adds a startup fetch even when the user never visits the home page.
void loadOpenInstances()
.then(importOpenInstances)
.then(() => checkAllInstances(FRESH_MS));
void loadHomeExamples();
- Files reviewed: 6/12 changed files
- Comments generated: 0 new
- Review effort level: Lite
| * order the cards should show, to change the Quick start examples: the file | ||
| * is fetched at runtime, not bundled, so no build or release is needed. | ||
| */ | ||
| const HOME_EXAMPLES_PATH = '/home-examples.json'; |
There was a problem hiding this comment.
Fetch from online: https://beacon-datalake.org/home-examples.json
…round when cors header error
There was a problem hiding this comment.
🟡 Changes recommended
It has two confirmed UI/data issues that can break the homepage layout and erase cached example data.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Suppressed comments (1)
src/routes/+page.svelte:220
max-width: 32.7%on grid items forces the Launchpad card to stay narrow. Only one card renders now.
:global(.card) {
padding: 0;
overflow: hidden;
max-width: 32.7%;
}
- Files reviewed: 6/12 changed files
- Comments generated: 1
- Review effort level: Lite
| const examples = parseExamples(await response.json()); | ||
|
|
||
| homeExamplesStore.set(examples); | ||
|
|
||
| return examples; |
New home page #94