Features/UI visual updates - #89
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It introduces two small correctness issues that can cause runtime or status-check inconsistencies.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates query-builder UI behavior and labels, and it fixes Beacon instance health refresh after edits.
Changes:
- Auto-scroll the query-block row so the active block stays fully visible, and set a thin scrollbar.
- Trigger an immediate instance health check after saving a Beacon instance so status updates without reload.
- Rename “Workbench” text to “Query Builder” on the saved queries page.
File summaries
| File | Description |
|---|---|
| src/routes/queries/saved/+page.svelte | Update saved query action label and tooltip to “Query Builder”. |
| src/lib/components/query-builder/QueryBuilderSelectorBlock.svelte | Add active-block auto-scroll logic and thin scrollbar styling. |
| src/lib/components/modals/AddBeaconModal.svelte | Start an immediate health check after save to refresh instance status. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| // The table shows this instance right away. Without this, its status stays | ||
| // "unknown" until the next sweep or page reload. | ||
| void checkInstance({ url, token }); |
| }); | ||
| } | ||
|
|
||
| let rowEl: HTMLDivElement | undefined = $state(); |
sharppaul
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto scroll query blocks so selected query block is always completely visible. slim scrollbar.
new beacon instance status was not getting updated until page reload. fixed.
renamed workbench to query builder on saved queries page.