Skip to content

Close the Flight SQL cursor before the connection #495

Description

@robinskil

Problem

Three Flight SQL tests close the connection while a statement stays open. The pinned driver adbc-driver-manager 1.3.0 raises:

RuntimeError: Cannot close AdbcConnection with open AdbcStatement

The assertions pass. Only the teardown step fails.

Failed tests

  • test_flight_sql.py::test_flight_select_constant
  • test_flight_sql.py::test_flight_query_parquet
  • test_flight_sql.py::test_flight_returns_arrow

Task

  1. Call cur.close() before conn.close() in each test.
  2. Run the file again.

Environment

Branch features/reimplement-atlas. Image beacon-integration:local.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingeffort-S1 to 3 dayspythonPull requests that update python code

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions