Add support for zarr - #101
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces comprehensive Zarr array support to the project by adding a new beacon-arrow-zarr crate and integrating it with the existing DataFusion-based file format system. The implementation provides efficient streaming access to Zarr data with Arrow interoperability, predicate pushdown capabilities, and support for CF conventions.
- Adds new
beacon-arrow-zarrcrate with async streaming, attribute handling, and data type conversion - Integrates Zarr format into the existing file format framework with DataFusion support
- Implements array slicing and predicate pushdown for efficient query processing
Reviewed Changes
Copilot reviewed 27 out of 65 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| beacon-arrow-zarr/Cargo.toml | New crate configuration with Zarr, Arrow, and async dependencies |
| beacon-arrow-zarr/src/*.rs | Core Zarr-to-Arrow conversion modules including streaming, attributes, and data types |
| beacon-arrow-zarr/test_files/ | Test fixtures with Zarr metadata JSON files for testing |
| beacon-formats/src/zarr/ | DataFusion integration modules for Zarr file format support |
| beacon-formats/src/lib.rs | Registration of new Zarr format factory |
| beacon-data-lake/src/table/ | Table format extensions to support Zarr file format |
| Cargo.toml | Workspace updates to include new crate and dependency changes |
Comments suppressed due to low confidence (1)
beacon-formats/src/zarr/mod.rs:1
- Typo in comment: 'reprensents' should be 'represents'.
use std::{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new crate,
beacon-arrow-zarr, to the workspace, providing foundational support for reading and streaming Zarr array data with Arrow interoperability. The update includes new Rust modules for handling Zarr data types, array slicing, attributes, and streaming, as well as the addition of test fixtures for Zarr arrays. There are also minor dependency updates and workspace configuration changes.New crate and Zarr/Arrow interoperability:
beacon-arrow-zarrcrate to the workspace, with its ownCargo.tomland dependencies for Zarr, Arrow, and related libraries. [1] [2]beacon-arrow-zarr:array_slice_pushdown.rs: DefinesArraySlicePushDownfor efficient dimension-based array slicing.attributes.rs: Handles conversion between JSON attributes and Arrow data types.data_types.rs: Maps Zarr data types to Arrow data types.stream.rs: Provides an async stream interface (ArrowZarrStreamComposer,ArrowZarrStream) for reading Zarr data as Arrow batches, including support for chunking and array slicing.lib.rs: Exposes the new modules.Test data and fixtures:
beacon-arrow-zarr/test_files/gridded-example.zarr/for arrays likeanalysed_sst,analysis_error,lat, andlon. These serve as test fixtures for the new Zarr reading functionality. [1] [2] [3] [4]Dependency and configuration updates:
Cargo.toml:beacon-arrow-zarrto the workspace members.serdedependency version constraint and addedcrossbeamas a workspace dependency.These changes lay the groundwork for robust Zarr array support in the project, enabling efficient, Arrow-based access to multi-dimensional scientific data.