Repository navigation
Merge upstream quattro (single sudo auth, leftover Hermes/OM-SEC-12/OWE) - #51
Merged
Merged
Conversation
Replace the shell's desktop video path with OWE
Use Omasnap for screenshots
…-test Retire the shipped Copy URL migration test
Point shell documentation to the canonical reference
Remove stale migration filename assertion
Remove obsolete repository scan from locate test
…onment Isolate About tests from inherited NO_COLOR
…ronment Isolate pacman tests from inherited LC_ALL
…environment Fall back to connected Wi-Fi when QR route lookup fails
Report skipped checks separately in shell tests
Remove link to Omarchy 3 manual
…se-on-retroarch-remove Drop libretro-database-git when removing RetroArch
Dropbox install not flagged as needing sudo
…ditor-uses-subl Use subl for the Sublime Text default editor
The lock view now isolates the OWE video feed behind a Loader. Keep the fork-only assertion that face chrome is not loaded as a plugin Item, and require that the only Loader is LockFeedSurface. Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
…-shell Let the Elsewhen migration survive a shell it cannot reach
Rename the Elsewhen migration so the link repair reaches machines that already ran it
…teral Treat command operands as literal values
Add select all and standard terminal clipboard shortcuts
…macs-icons Add editor icons for Sublime Text and Emacs
…-update Isolate OCaml cleanup authorization
…sible-hover-states Fix invisible hover and active states in the generated VS Code theme
…ible-states Fix invisible VSCode status bar labels and current line
Point catppuccin theme at its flavour colorscheme
Make VS Code-family editors reload the Omarchy theme when it changes
…wallpapers Remember the selected wallpaper for each theme
Upstream now writes a real theme file and versions the local extension from palette content so VS Code reloads. The CLI fixture still expected a symlink to 1.0.0. Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
Only force NVIDIA VA-API/GLX env when NVIDIA drives the display
Install Hermes for the default agent as the desktop app's self-updating runtime Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
…ycles-20260923 Guard against cyclic theme colour references
…-inhibitor-identity [codex] OM-SEC-12: Bind update inhibitor cleanup to process identity Reported-by: Afonso "AFOliveira" Oliveira Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
Migrate remote Neovim providers to reliable clipboard yanks and paste
Official product updates still run after mise, each behind a cold sudo boundary. Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
* Ask for the sudo password once per omarchy update Every sudo call in omarchy update prompted, because the no-update wrapper covered the whole run on top of per-phase revokes, and stay-awake revoked the timestamp on its own entry and exit. A single update could ask four times before the snapshot finished (omacom#13319). Authorize once, right after confirmation, starting from a revoked timestamp so the prompt always belongs to this update. A background keepalive refreshes it until the update is done. Prune, snapshot, stay-awake, keyring, system packages, migrations, orphan removal, service restarts, the post-update hook, and mise all share that authorization. AUR builds run third-party PKGBUILD code, so they move to the end and run cold: the keepalive stops, the timestamp is revoked, and yay and any bare sudo use the no-update wrapper. The timestamp is revoked again after AUR and on every exit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Keep the single authorization for passwordless sudo and ttyless inhibition Authorize by running a command instead of sudo -v. Under the default verifypw=all, -v prompts even when passwordless sudo is enabled, which would have added a prompt those users never had. Inside an update without a terminal, stay-awake now reuses the update's authorization with a non-interactive sudo instead of asking again through polkit. It falls back to polkit only if that authorization is gone. The test sudo refuses a cold non-interactive call, as the real one does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stopping stay-awake sends TERM to the held process, which was an exec'd sleep. systemd-inhibit reports a child killed by a signal as an error, so every update ended with "'/usr/bin/setpriv' terminated by signal TERM." The held process now stays a shell that traps TERM, kills its sleep, and exits cleanly. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Now that every package we offer an installer for no longer needs it
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks leftover PR #50 (which already includes leftover #49, #48, #45, and #42) plus the 3 new first-parent / 3 non-merge omacom/omarchy
quattrocommits since that sync onto this fork’s currentquattro(13502987, face holds on swapped frames from #46).Upstream moved from
7b336b1btoc5b4db77. A rawgit mergeof upstreamquattrois still not a fast-forward — earlier cherry-pick syncs already landed those commits — so this is leftover #50 plus the new first-parent commits only. #50, #49, #48, #45, and #42 are still open and are superseded here. Face draft #47 is left alone.Fork-only Cursor and face/lock work is untouched: official-tarball installer, no mise wrapper, usage collector, Cursor/Grok update steps, the theme-set fix from #22, and face scan #26–#40 / #43 / #46. The OWE lock-feed Loader stays isolated; the face card and presented/swapped-frame holds remain on the lock and polkit surfaces.
omarchy-theme-set-vscodestill does not theme Cursor.New since PR #50
One sudo password per
omarchy update(upstream omacom#13323)sudo -v, so passwordless sudo still needs no prompt. Ttyless stay-awake reusesOMARCHY_UPDATE_SUDO_SESSION=1instead of asking again through polkit.omarchy-update-grok-botandomarchy-update-cursorstill run after AUR, each with their own revoke and the no-update wrapper. Both are stubbed insudo-boundary-test.shso the copied updater can finish.Stay-awake stop no longer errors on TERM (upstream omacom#13361)
sleep. systemd-inhibit treated a child killed by a signal as an error, so every update ended with' /usr/bin/setpriv' terminated by signal TERM.AUR menu entry moved down
install.auris no longer the second Install item. It now sits after Windows / before Preinstalls, now that shipped installers no longer need it.Leftover from PR #50 (still not on quattro)
Hermes Desktop is the default-agent runtime (upstream omacom#12844)
~/.hermes. Nothing is stubbed through mise; provision no longer callsomarchy-install-hermes-cli || true.omarchy-install-cursor-agent), notomarchy-mise-install cursor-agent.OM-SEC-12 (upstream omacom#9467), now reshaped by omacom#13323
OMARCHY_PATHmust match the running entrypoint, command-scoped--no-updatesudo, fail-closed expiry, and inhibitor cleanup bound to owned process identity.Hybrid NVIDIA VA-API/GLX (upstream omacom#11690)
omarchy-hw-nvidia-displayreads cached sysfsboot_vga. Hyprland applies NVIDIA VA-API/GLX env only when NVIDIA drives the display.Omasnap autosaves by default (upstream omacom#13218)
Cyclic theme colour references (upstream omacom#13046)
shell/Commons/Color.qmltracks visited roles and returns the supplied fallback instead of recursing forever.Remote Neovim clipboard yanks (upstream omacom#11486)
1788996284upgrades known Omarchyremote_clipboard.luaproviders atomically. Needsomarchy-nvim2026.9.21-2 or newer before it will mark an unrepaired provider complete.Fastfetch, wallpaper memory, VS Code, Elsewhen, OWE, Omasnap (leftover from #49/#48/#45/#42)
--no-update;owe/owe-lockfeed;omasnapreplaces Satty/Tensaku.Fork-only adaptations
lock-face-test.shstill allows the isolated OWEfeedLoaderwhile forbidding a plugin Item next to the password field. Face card, Howdy PAM, and lock/polkit chrome — including presented-frame and swapped-frame holds from fix(shell): play face results on presented frames #43/fix(shell): play face holds on swapped frames #46 — are unchanged.test/clistill asserts a copied theme file,_watch: true, and a content-hashed extension version.Tests
Passed locally on this branch:
./test/clitest/shell.d/update-sequence-test.shtest/shell.d/update-hook-security-test.shtest/shell.d/update-user-path-test.shtest/shell.d/update-disk-space-test.shtest/shell.d/update-restart-phases-test.shtest/shell.d/channel-sudo-boundary-test.shtest/shell.d/channel-test.shtest/shell.d/security-entrypoint-symlink-test.shtest/shell.d/security-source-root-test.shtest/shell.d/nopasswd-sudo-expiry-test.shtest/shell.d/menu-guards-test.shtest/shell.d/update-cursor-test.shtest/shell.d/update-grok-bot-test.shKnown sandbox skips, same as quattro:
update-stay-awake-security-test.sh(needs a private XDG runtime dir),update-lock-test.sh(/run/user/$UID),locate-test.sh,passwordless-grant-lifecycle-test.sh(companionomarchy-pkgscheckout older than OM-SEC-12).