Repository navigation
Merge upstream quattro (no-animations VMs, browser handoff, SSH agent, YT6801) - #53
Closed
cursor[bot] wants to merge 23 commits into
Closed
cursor[bot] wants to merge 23 commits into
cursor[bot] wants to merge 23 commits into
Conversation
Reported-by: Sean Huber
Reported-by: Sean Huber
…9399) * Add SSH Agent as an optional service install Enables gcr-ssh-agent (already shipped via the gnome-keyring dependency) so passphrase-protected SSH keys work from any context: the agent prompts graphically on first use, with opt-in passphrase storage in the keyring. Adds install/remove commands and Install > Service / Remove > Service menu entries. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BReZWvvLsDRUaqgjiRzvZ5 * Clear the agent's SSH_AUTH_SOCK when removing the SSH agent service The socket's ExecStartPost exports SSH_AUTH_SOCK into the user manager with set-environment, which disabling the socket does not undo, so apps launched after removal still pointed at a stopped agent. The environment.d file also has to be deleted before disable reloads the manager, or the generator re-exports it. Only an SSH_AUTH_SOCK pointing at gcr is cleared, so another agent's stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Move SSH Agent setup to Setup > Security Turning on an SSH agent is security configuration of the machine rather than installing software, so it sits with SSHD and the other Setup > Security entries. It hides once enabled, as Sudoless Docker does, and Remove > Service > SSH Agent turns it back off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: David Heinemeier Hansson <david@hey.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
) * Read the default browser from mimeapps.list when launching omarchy-launch-browser and omarchy-launch-webapp asked xdg-settings for the default browser on every launch, ~72ms through several POSIX shell scripts. The new omarchy-cmd-default-browser reads the http handler from the config-dir mimeapps.list files the way xdg-mime does, desktop-specific list first, taking the first listed entry whose command is installed, in ~10ms. With nothing set there it falls back to xdg-settings as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Let the first copy of a browser entry decide whether it is installed A user-local entry whose browser is gone could be rescued by a system copy of the same ID, which the launchers never read. xdg-mime judges the first copy found, as the launchers use it, so do the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…13521) To open a new terminal in the focused terminal's directory, the launcher asked Hyprland for the active window with hyprctl, ~10ms on every SUPER+RETURN. The binding now reads the pid from hl.get_active_window() and passes it as --pid. Without one, from the menu or a shell, the launcher asks Hyprland as before. The bind is now a Lua function, which Hyprland reports only as __lua, so o.bind_commands records the command it stands for and the keybindings menu still launches a terminal when the entry is picked. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…macom#13522) * Collapse identical notifications from the same sender into one toast A web app open in several tabs fires one notification per tab for a single reminder, stacking identical toasts. A new notification matching an on-screen toast's app, summary, and body now replaces it like a replaces_id update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Only collapse live duplicates that share image and click target Screen recording toasts share text but preview and open different files, and replayed history rows share images with entries still in history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Compare a notification's current content when collapsing duplicates A replaces_id update can land while the insert is deferred, so the initial snapshot may no longer describe what the notification says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…acom#13530) * Hand browser and web app launches to the running browser directly With a Chromium-based browser already running, each launch started a second browser process only to pass its command line over the profile's singleton socket and exit, ~165ms before the running browser even heard of it. omarchy-cmd-browser-handoff sends that message itself with socat and waits for the ACK, so a web app opens in ~210ms instead of ~430ms. It hands off only what it can do exactly as the browser would: the packaged browser binary rather than a wrapper, a flags file holding nothing beyond the process flags Omarchy ships, no other data directory, and a socket we own. Anything else, or no answer, launches the browser as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Hand Brave Origin launches to the running browser too /usr/bin/brave-origin is the package's own launcher, reading brave-origin-flags.conf, with the profile in BraveSoftware/Brave-Origin. A web app now opens in ~158ms instead of ~345ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
A machine without a GPU, like most VMs, renders through llvmpipe on the CPU, where every animated frame and every translucent window costs. In a VM, opening and closing a terminal took ~5s of CPU; a panel ~3.4s. omarchy toggle animations (also under Toggle > Animations) places a Hyprland flag that turns off animations, blur and shadows and makes windows opaque. The shell follows Hyprland's animations:enabled, rereading it on every config reload: its one-shot animations run for Style.duration(ms), which is then 0, and its spinners, pulses and title marquee hold still. A new install in a VM starts with the flag in place. Measured in the ISO test VM (llvmpipe), CPU per interaction: terminal open+close 5000ms -> 481ms, workspace switch 1670ms -> 409ms, audio panel 3446ms -> 796ms, volume OSD 2324ms -> 584ms, menu 2028ms -> 1241ms. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
fzf's completion.bash rewraps the completions of ~76 commands on every interactive shell start, costing ~25ms once bash-completion is loaded. Keep only the key bindings (Ctrl-R, Ctrl-T, Alt-C); **<Tab> fuzzy completion goes. `starship init bash` only prints a line that runs starship again with --print-full-init, so call that directly and start the binary once. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Upstream no-animations mode zeros Style.duration. The fork's face and password opacity fades were still hardcoded, so they would keep running in VMs. Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the 22 non-merge omacom/omarchy
quattrocommits after PR #52's marker onto this fork'squattro(7afb44b6, after the #47 face-card merge). Upstream moved from3faafba2toe332dc97. Commits are applied oldest-first, one fork commit per upstream commit, no full merge, following the fork's sync method.No leftover sync PRs remain: #52 and the face-card #47 are already on
quattro.What comes in
mimeapps.list(~10 ms instead of ~72 ms throughxdg-settings) (Read the default browser from mimeapps.list when launching omacom/omarchy#13520). With a Chromium-based browser already running, web apps are handed to that process over the profile singleton socket (~210 ms instead of ~430 ms; Brave Origin too) (Hand browser and web app launches to the running browser directly omacom/omarchy#13530). Super+Return passes the focused window pid from Lua so a new terminal skipshyprctl(~10 ms) (Hand the terminal launcher the focused window's pid from Lua omacom/omarchy#13521).starship --print-full-initonce.omarchy toggle animations(Toggle > Animations) writes a Hyprland flag that turns off animations, blur, and shadows. The shell followsanimations:enabledthroughStyle.duration(ms). In the ISO test VM, terminal open+close went 5000 ms → 481 ms.gcr-ssh-agentso passphrase-protected keys prompt graphically. Hides once enabled; Remove > Service > SSH Agent clearsSSH_AUTH_SOCKwhen it pointed at gcr./var/lib/fprint/$usertemplates, resolving the caller strictly by UID (Remove saved fingerprint templates for the invoking user omacom/omarchy#13049).Conflicts resolved
All six overlapping files auto-merged. Fork-only lines stayed; upstream additions landed beside them.
bin/omarchy-remove-security-fingerprint: keptomarchy-pam-pair-drop/omarchy-apply-polkit-pam; added UID-safe template deletion.default/omarchy/omarchy-menu.jsonc: kept Face / Cursor / Grok entries; added Animations toggle and SSH Agent setup/remove.install/omarchy-other.packages: kept forklinux/linux-headers; droppedyt6801-dkms.shell/plugins/agents/Panel.qml: kept Cursor limit-window extras; wrapped meter animations inStyle.duration.shell/plugins/polkit/PolkitAgent.qml: kept face chrome; wrapped the shake inStyle.duration.test/cli: kept fork theme assertions; added Hunk sync coverage.Fork-only adaptation
shell/plugins/polkit/PolkitAgent.qmlface/password opacity fades now useStyle.duration(160)so they hold still when animations are off. Upstream only wrapped the stock shake.Fork delta check
git diff --name-only <upstream tip> <fork tip>covers the same 155 files before (3faafba2vsquattro) and after (e332dc97vs this branch).Tests
./test/clipasses, including the new Hunk sync cases.shell-ipc-socket-test.shis 14/14 withsocatinstalled.browser-handoff-test.shskips here (no/usr/bin/chromium)../test/shellhas the same sandbox-only failures as onquattro: notimedatectl, no private XDG runtime, no pacman/mise,updatedb --debug-pruning,/run/lockunwritable, andPREPARED_BACKGROUND_SNAPSHOTunbound. None of those files were in this upstream batch.Not done: a visual check on real hardware. There is no compositor in the cloud sandbox.