Repository navigation
Merge upstream quattro (T2 firmware fetcher, clipboard hangs, Elsewhen remove buttons) - #61
Merged
Merged
Conversation
Fix grammar in navigation manual Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
* Bound clipboard capture reads * Bound the watched clipboard read and drop copies cut off at the deadline In watch mode capture.sh reads the copy from the owner's pipe on stdin, to EOF, with no bound. An owner that stalls without closing its end keeps the callback alive, and wl-paste --watch handles no further clipboard events until it exits. That matches omacom#9443, whose stuck capture.sh had no wl-paste child: --list-types never reads from the owner. Every read now goes through one bounded reader into a temporary file, and the copy is recorded only when the read finished, so a snapshot that stalls halfway no longer records its first half. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Omarchybot <317366263+omarchybot@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…etcher Name apple-bcm-firmware-fetcher in the T2 package list Keep the fork linux / linux-headers ISO entries next to linux-omarchy. Co-authored-by: Mark Groves <mark-groves@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks the 5 new first-parent / 7 non-merge omacom/omarchy
quattrocommits onto this fork'squattro(27c52d26, after merged PR #60). Upstream moved from2f7302a7to81145eb1. Commits are applied oldest-first, one fork commit per first-parent commit, no full merge. No leftover sync PRs.New since last check (2026-10-04 /
2f7302a7)apple-bcm-firmwareis replaced byapple-bcm-firmware-fetcherin the T2 install script and the ISO package list. The fetcher reads Wi-Fi firmware off an on-disk macOS volume (the only legal source for T2 Broadcom firmware). A single-boot wipe of macOS has no such volume, so those machines still need firmware from a macOS copy or a downloaded recovery image. The superseded package is no longer added. The fork still keepslinuxandlinux-headersnext tolinux-omarchyininstall/omarchy-other.packages.capture.shused to read the owner's pipe to EOF with no bound. A stalled owner (no close) left the watch callback alive, andwl-paste --watchstopped seeing further events. Every read now goes through a 2s bounded reader into a temp file; a copy cut off at the deadline is dropped, not kept as a partial entry. Watched text still survives a stalled--list-typesquery.Fork-only lines kept
install/omarchy-other.packagesstill listslinuxandlinux-headersfor the fork's default-kernel policy. Only the T2 firmware package name changed.Fork delta check
git diff --name-onlyvs upstream81145eb1is still 157 files (same as after Merge upstream quattro (fingerprint recovery, Microsoft web apps, leftover usage/OpenClaw/picker) #60 vs2f7302a7). The seven files that only moved on upstream now match;omarchy-other.packagesstays in the delta because oflinux/linux-headers.Tests
./test/clipasses.test/shell.d/clipboard-test.shpasses, including the new stall / partial-copy / watched-owner-timeout cases.test/shell.d/t2-hardware-test.shpasses, including the firmware-fetcher package-list assertions.elsewhen-pointer-test.shskips (qt6 qmltestrunnernot on this image).elsewhen-greetings-test.shand oneelsewhen-model-test.shassertion fail here becausetimedatectlneeds systemd; same on quattro27c52d26.Not done: a visual check of the Elsewhen hover/× bubble on real hardware. There is no compositor in the cloud sandbox.