Repository navigation
ci(pr): require a sync, a capped topic, or a native stack onto quattro - #83
Merged
Merged
Conversation
Nothing writes the USB and Thunderbolt polkit actions anymore. The comment that said default/polkit copies them was false. Co-authored-by: ai <ai@id.grovr.au>
A topic on quattro may change at most 40 files. Over that, the check tells the author to split into a stacked pull request set whose root targets quattro. The same job runs the layout and polkit shell tests. A merged pull request must keep the base tip it named as the merge commit's first parent. Co-authored-by: ai <ai@id.grovr.au>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a9748a2. Configure here.
i18n-sync is the auto-PR that collects translations onto quattro. A full collect changes more than 40 files, so the topic cap blocked it. The cap stays a hard failure for every other topic, with no override label. Co-authored-by: ai <ai@id.grovr.au>
The closed event's base SHA lags the branch GitHub merged onto, and a rebase of more than one commit does not parent that snapshot. Fetch the named branch and accept the merge when that branch contains it, or when its tip is still what the first-parent chain reaches. Co-authored-by: ai <ai@id.grovr.au>
Read the stack trunk from GitHub's native stack metadata, falling back to walking open pull requests, so a stack of any depth whose bottom targets quattro passes. Hold every topic and stack layer to the 40-file cap against its own base, and reject upstream commits outside a sync branch. Drop the post-merge check: it could only report after the fact and native stack merges would trip it. The tests now use local fixtures instead of a hard-linked clone, which failed when /tmp is on another filesystem. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
Agents have landed upstream imports on
quattrounder topic titles (#78, 1150 files) and merged a hand-built stack layer straight ontoquattro(#75). Stacked pull requests are the preferred way to split work, and GitHub's native stacks are now generally available, so this check makes small native stacks the easy path and rejects the shapes that caused those incidents.What the check enforces
cursor/upstream-changes-pr-*,cursor/fork-upstream-updates-*,i18n-sync): targetsquattro; only one upstream sync open at a time.i18n-syncand an upstream sync don't block each other. Syncs are not capped.quattromust sit in a stack whose trunk isquattro. The trunk comes from GitHub's native stack metadata (PullRequest.stack.baseRefNameover GraphQL), falling back to walking open pull requests for hand-built stacks.quattrothat its base lacks. Stacking on the open sync is fine.The post-merge check is gone: it could only report after the fact, and native stack merges land layers on
quattro, which it would have flagged.AGENTS.mdgains a Pull Requests section telling agents to build stacks withgh stackand merge them bottom-up through GitHub.The unrelated-looking polkit commit removes two allowlist entries upstream no longer has; nothing installs those files and the migration deletes them.
Verification
bash test/shell.d/pr-shape-check-test.sh: 17 cases pass, using local git fixtures (no hard-linked clone, so it works with/tmpon tmpfs).stackfield is documented; if it errors, the check falls back to walking open pull requests.🤖 Generated with Claude Code