Repository navigation
Merge upstream quattro (drop notification snooze and panel) - #92
Merged
Merged
Conversation
Drop per-source and global snooze, the PipeWire screen-share detection that offered one, and the bell's snoozed and sharing states. The bell is a plain Do Not Disturb toggle again (right-click still opens the panel), the panel's held-back list follows Do Not Disturb only, and right-clicking a card dismisses it. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Drop the panel behind a right-click on the bell, its preferences page, and the `notifications` settings in shell.json. Notifications follow the focused display, step aside for fullscreen windows, keep a day of history, and always let verification codes through Do Not Disturb. The bell is a plain Do Not Disturb toggle, and Super+Shift+Alt+, still puts the last few back on screen, held back or not. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
quattromoved from967bbdd7(already on the fork via #91) tocbd44ba1(2026-10-23 19:04 UTC). 2 first-parent commits, both non-merges, cherry-picked onto forkquattro. Cursor stays on the official tarball. Face, Grok Bot, and Cursor menu entries stay. The power-profile menu provider stays out. Thekernelsprovider stays. Fingerprint setup still goes throughomarchy-pam-pair-addandomarchy-apply-polkit-pam. Factory reset still scrubs inherited USBGuard and Thunderbolt trust. The icon font charset stayse900-e90f; Tailscale stays at U+E90F and Cursor at U+E90D. The fork overlay is still 231 paths, the same set as against967bbdd7. The only file both sides touch isdefault/i18n/en/shell.json; the fork hunks there (face strings, no power-profile menu strings, noagents.helpStartToSeeLimits) are unchanged. Every other overlay hunk matches.Snooze and the screen-sharing offer are gone (omacom#16429)
Per-source snooze and snooze-everything are gone, along with the PipeWire screen-share detection that offered a timed snooze. Right-click on a card dismisses it (the zzz control is gone). The bell no longer has snoozed or sharing states. Held-back cards follow Do Not Disturb only.
quiet.jsonis{ dnd }.The notification panel and its preferences are gone (omacom#16430)
Right-clicking the bell no longer opens a panel. The preferences page is gone, and so are
NotificationPanel.qml,Picker.qml, andSettings.js. There is nonotificationsobject inshell.jsonanymore: no display picker, no history-length setting, no fullscreen-overlay switch, no "let codes through" switch.What remains is fixed:
Super + Shift + Alt + ,puts the last few back on screen, held back or not.Super + Ctrl + ,still flips the same switch).notify-send. Silenced rows are still recorded in history; ephemeral ones are dropped.English shell strings for snooze, the panel, and those preferences are removed. Other languages may still carry the old keys; the structural i18n check allows that.
test/shell.d/notifications-test.shandtest/shell.d/i18n-test.shpassed.