feat(monitors): aggregate service status across active monitors#2
Merged
Conversation
Prior behavior: the most recent monitor check unconditionally overwrote the linked service's status. With multiple monitors per service this caused recovery in one monitor to mask real outages in another. New behavior: when applying a status change, compute the worst (per _STATUS_PRIORITY) across all active monitors on the service, treating the just-completed monitor's candidate as its current contribution. Service status is updated only when the aggregated state actually changes. Preserves: - Single-monitor services: identical behavior. - Maintenance mode: still wins, untouched. - API-set status (token_auth, admin): untouched, bypasses aggregation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior behavior: the most recent monitor check unconditionally overwrote the linked service's status. With multiple monitors per service this caused recovery in one monitor to mask real outages in another.
New behavior: when applying a status change, compute the worst (per _STATUS_PRIORITY) across all active monitors on the service, treating the just-completed monitor's candidate as its current contribution. Service status is updated only when the aggregated state actually changes.
Preserves: