Compatible for Python 2 and 3#5
Compatible for Python 2 and 3#5PanderMusubi wants to merge 1 commit intomarkkness:masterfrom PanderMusubi:master
Conversation
|
Looking at this briefly, it looks basically reasonable, but I have not had a chance to test it. For Python2.x, it might need some import from future to get the Python3 style print behavior. That might be needed. (I'm not sure.) This should work on 2.x and, with your improvements, 3. Also, some of the changes are whitespace only. Can you remove those? They make the diff harder to read. Your new whitespace might be better anyways but it adds confusion. Thanks! |
|
The trailing white spaces were removed by my editor (atom). They serve no purpose and are best removed. The movement of some # from beginning of the statement to the beginning of the line was done because flake and pep8 were complaining. For the lines I have edited, I also fixed all warnings from flake and pep8. Hence the patch as it is now. Please review it with the white spaces. Other white spaces I haven't touched. |
|
I think I have now made most all of the changes that you suggested, and tested them on Python 2.7. I did not merge this PR explicitly, one reason is that I do not want to have to follow pep8. (I agree with many but not all of its suggestions.) But I have made changes for the following:
With the changes, which are now in So could you test the updated |
|
Also note that I have just updated |
Please check thoroughly, especially if the range and raise are ported properly.