fix(loader): accept 'source' as fallback for Iframe src attribute#6
Open
Sappique wants to merge 1 commit into
Open
fix(loader): accept 'source' as fallback for Iframe src attribute#6Sappique wants to merge 1 commit into
Sappique wants to merge 1 commit into
Conversation
Iframe component tables in several chapter Google Docs use a `source` row name instead of `src`. The transformer only reads `attrs.src`, so the iframe is rendered with no URL and the page shows an infinite loading spinner. Reading `attrs.src ?? attrs.source` tolerates both conventions. Refs markov-root#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcerow name instead ofsrc.convertIframeonly readsattrs.src, so ~15 interactive figures across 9 sections render with an empty iframe URL and an infinite loading spinner.attrs.src ?? attrs.sourceso the transformer tolerates both conventions.Closes #5.
Tested:
pnpm devlocally and verified previously broken figures now render correctly, including the two on/chapters/v1/evaluations/benchmarks/.src) still render correctly — no regression.