-
-
Notifications
You must be signed in to change notification settings - Fork 139
Merge RAK4631 PMU logic from CE firmware + button change #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Great stuff, this is looking good! I'll merge this in before the next release! Thanks for the contribution! |
That's a good idea, but what's the deal with the users using IO adapters? |
|
@memo-567 you have a valid point, however it seems redundant to use an IO module to expose a single pin (there are no other uses for the IO on an RNode). It feels more "correct" to have this as the default Maybe in the future we could have rnodeconf specify the user pin. It likely applies in a similar way to a lot of boards. |
|
I also noticed today that the RAK does not have the sleep logic implemented. Ill try add that too |
|
Hmm, there's some good points here. If some people are already using the IO module as default, this should probably be a configurable option with |
|
Sleep now sets the display backlight to zero, disables external peripheral power, and sleeps the MCU. Testing: It would be nice if someone could verify that it works for them too. I've attached my build. |
|
Good stuff. I don't really have much RAK hardware to test with here, so hopefully someone else can jump in and check it out. |
The liberatedsystems/RNode_Firmware_CE has some PMU/Battery logic for the RAK4631. The voltage curves probably need some tweaking.
I also switched the user button to pin 31 as this is accessible from the board without having to add an IO module. See https://store.rokland.com/pages/adding-a-user-button-rak19007 for details.
Built and confirmed running on my own RAK4631