fix(editor): keep visual line clicks aligned - #701
Merged
Conversation
Move heading, paragraph, and blockquote spacing into measured CodeMirror block widgets so virtual heights match the rendered layout. Closes #700
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
CodeMirror maps pointer coordinates through a virtual height model. Vertical padding and margins applied directly to editable lines were not represented reliably in that model, so the rendered document became taller than CodeMirror expected and clicks landed on later lines. The drift accumulated in heading-rich documents on both desktop and web.
Validation
cd packages/editor && pnpm test && pnpm build && pnpm typecheck:test— 39 test files and 511 tests passedcd packages/app && pnpm exec vitest run src/styles.test.ts src/components/CodeMirrorPaperSurface.test.tsx --environment jsdom --globals && pnpm build && pnpm typecheck:test— 2 test files and 105 tests passed3.1.1,3.1.2, and quoted paragraph rows keep the caret on the clicked visual linegit diff --checkpassedRisk
Screenshots
Not included because the intended visual spacing is unchanged; this fixes pointer-to-caret alignment.
Closes #700