fix: stabilize Windows frontmatter input and window sizing - #707
Open
murongg wants to merge 1 commit into
Open
Conversation
Defer frontmatter synchronization until IME composition ends. Preserve the restored client size when hiding native menus. Refs #706
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The frontmatter textarea dispatched CodeMirror transactions and restored focus and selection for every composing input event, which could transfer the active IME composition into the main editor. On Windows, the window-state plugin restored the client size while the native menu was attached; hiding the menu afterwards expanded the client area and saved a larger height for the next launch.
Validation
pnpm --filter @markra/editor test— 39 files and 524 tests passedpnpm --filter @markra/editor buildpassedpnpm --filter @markra/editor typecheck:testpassedcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml— 286 tests passedcargo check --manifest-path apps/desktop/src-tauri/Cargo.tomlpassedpnpm --filter @markra/desktop buildpassedpnpm --filter @markra/desktop typecheck:testpassedcargo fmt --manifest-path apps/desktop/src-tauri/Cargo.toml -- --checkpassedgit diff --checkpassedRisk
Related issues
Refs #706