fix(editor): keep IME input inside table headers - #709
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Chinese IME input in an empty visual table header could be inserted as a stray node under the table row. This distorted the table into an apparent extra column and left the Markdown source unchanged.
Validation
pnpm --filter @markra/editor test— 39 test files and 525 tests passedpnpm --filter @markra/editor typecheck:testpassedpnpm --filter @markra/editor buildpassed苏打水in an empty header, confirmed the visual table stayed at two columns, then confirmed source mode showed| 1 | 苏打水 |Risk
Low. The change is limited to IME composition handling in visual table cells, and the zero-width caret marker is removed during Markdown serialization.