Skip to content

Add on-demand Kimi PR review - #35

Merged
marlian merged 1 commit into
mainfrom
ci/kimi-review-on-demand
Sep 23, 2026
Merged

marlian merged 1 commit into
mainfrom
ci/kimi-review-on-demand

Conversation

@marlian

@marlian marlian commented Sep 23, 2026

Copy link
Copy Markdown
Owner

Summary

Adds Kimi Code PR review adapted from legate's kimi-review.yml, but on demand to save plan quota:

  • it runs only when the kimi-review label is added to a PR, or from the Actions tab (workflow_dispatch);
  • to review new pushes, remove the label and add it again.

What matches legate:

  • the action pin marlian/kimi-code-reviewer@72e9e6c (v2.2.0 + reasoning + outcome + streaming);
  • the model settings: k3-256k, thinking enabled, reasoning_effort: max, timeout_ms: 900000;
  • fail_on: never, so a finding is a comment and Diana tripartite stays the gate;
  • the step-scoped secret guard and the context-budget fallback.

.kimi-review.yml has workmem-specific rules:

  • no silent project-mode fallback;
  • project/global isolation;
  • lifecycle guards;
  • parameterized SQL and FTS cleanup;
  • telemetry privacy;
  • 0700/0600 file modes;
  • multi-process SQLite safety;
  • reconcile audit;
  • production reachability;
  • a callout for any change to reviewer instructions.

Why a separate PR, merged first

The action reads .kimi-review.yml and the instruction files from the default branch through the GitHub API, so a PR can't rewrite its own review policy. This PR has to be on main before #34 can be reviewed with it.

Setup after merge

  • Repository secret KIMICODE_API_KEY (Actions). Without it the job skips cleanly with a summary note.
  • Label kimi-review.

Test plan

🤖 Generated with Claude Code

Kimi Code review spends plan quota, so it runs only when the `kimi-review`
label is added to a PR or from the Actions tab, never on every push. The
action pin, model (k3-256k, thinking, max reasoning), timeouts, step-scoped
secret guard and context budget fallback match legate. `.kimi-review.yml`
carries workmem's own contracts: no silent project-mode fallback, project and
global isolation, lifecycle guards, parameterized SQL, telemetry privacy,
private file modes, multi-process SQLite safety and reconcile audit rules.

The action reads .kimi-review.yml and the instruction files from the default
branch, so this must land on main before a PR can be reviewed with it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@marlian
marlian merged commit ff187fd into main Sep 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant