Repository navigation
wiring: fail on a dispatch it cannot read - #165
Merged
Merged
Conversation
…dispatches v0.15.0's notify-devkit put its type in a JSON literal that wiring.py could not read; the devkit's CI was green and only the umbrella's wiring --check, after the release, saw bump-ready with no sender. wiring.py now reports a repository_dispatch call that yields no readable type, against the calling workflow, and --check fails on it. wiring.py --lint-devkit [DIR] reads the devkit's own workflows, resolves its calls of itself (./ or the tagged org path) to the working tree, and fails on an unreadable dispatch or a repository_dispatch type no devkit workflow sends. devkit CI and just quality run it. Closes #163 Tested: wiring.py --self-test ok (7 new cases red, then green); --lint-devkit rc=0 here, rc=1 with both lines at v0.15.0; devkit-quality.sh rc=0 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.15.0's notify-devkit put its type in a JSON literal that wiring.py could not
read; the devkit's CI was green and only the umbrella's wiring --check, after the
release, saw bump-ready with no sender. wiring.py now reports a repository_dispatch call
that yields no readable type, against the calling workflow, and --check fails on
it. wiring.py --lint-devkit [DIR] reads the devkit's own workflows, resolves its
calls of itself (./ or the tagged org path) to the working tree, and fails on an
unreadable dispatch or a repository_dispatch type no devkit workflow sends.
devkit CI and just quality run it.
Closes #163
Tested: wiring.py --self-test ok (7 new cases red, then green); --lint-devkit rc=0 here, rc=1 with both lines at v0.15.0; devkit-quality.sh rc=0
Co-Authored-By: Claude noreply@anthropic.com