Repository navigation
skills-update drops its token secret fallback (pre-MIP-0086) - #170
Merged
Merged
Conversation
The workflow pushes and opens its PR with marola-pr-bot's token when the caller passes pr_bot_key, else with GITHUB_TOKEN. The optional token secret (an old PAT path) is no longer declared, as #132 did for notify-umbrella and gemini-review. No caller passes it today: marola-site and this repo pass pr_bot_key, the umbrella passes nothing. Closes #148 Tested: devkit-quality.sh (just quality's steps without Nix: actionlint, self-tests, docs_lint, release --check, merge_key_check, wiring --lint-devkit) rc=0; no skills-update caller in the umbrella, its submodules or this repo passes token: Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow pushes and opens its PR with marola-pr-bot's token when the caller passes pr_bot_key,
else with GITHUB_TOKEN. The optional token secret (an old PAT path) is no longer declared, as #132
did for notify-umbrella and gemini-review. No caller passes it today: marola-site and this repo pass
pr_bot_key, the umbrella passes nothing.
Closes #148
Tested: devkit-quality.sh (just quality's steps without Nix: actionlint, self-tests, docs_lint, release --check, merge_key_check, wiring --lint-devkit) rc=0; no skills-update caller in the umbrella, its submodules or this repo passes token:
Co-Authored-By: Claude noreply@anthropic.com