Repository navigation
runner-preflight drops the PR-creation check and its… - #171
Merged
Merged
Conversation
github-actions
Bot
changed the title
… advice The check probed whether the host token could open PRs and, for Scala Steward, recommended a STEWARD_GH_TOKEN PAT. Since MIP-0086 Steward mints a marola-pr-bot token, runs on ubuntu-latest, and marola-dev/marola#765 deleted that secret; only marola-ml's GPU publish may use the self-hosted runner. Nothing on the runner needs a token that opens PRs, so the probe, its verdict function, the host-token helper and their four self-test cases go. Closes #149 Tested: devkit-quality.sh (just quality's steps without Nix) rc=0; runner-preflight.sh --self-test ok; runner-preflight.sh on a non-runner host with gh signed out prints no Steward or PAT line; git grep STEWARD_GH_TOKEN -- scripts docs README.md prints nothing Co-Authored-By: Claude <noreply@anthropic.com>
brunogbv
force-pushed
the
chore/149-runner-preflight-steward
branch
from
October 17, 2026 11:09
2b84612 to
fb5002b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check probed whether the host token could open PRs and, for Scala Steward, recommended a
STEWARD_GH_TOKEN PAT. Since MIP-0086 Steward mints a marola-pr-bot token, runs on ubuntu-latest,
and marola-dev/marola#765 deleted that secret; only marola-ml's GPU publish may use the
self-hosted runner. Nothing on the runner needs a token that opens PRs, so the probe, its verdict
function, the host-token helper and their four self-test cases go.
Closes #149
Tested: devkit-quality.sh (just quality's steps without Nix) rc=0; runner-preflight.sh --self-test ok; runner-preflight.sh on a non-runner host with gh signed out prints no Steward or PAT line; git grep STEWARD_GH_TOKEN -- scripts docs README.md prints nothing
Co-Authored-By: Claude noreply@anthropic.com