This repository was archived by the owner on Sep 8, 2026. It is now read-only.
Repository navigation
Conversation
martomi
reviewed
Apr 16, 2026
Comment on lines
+15
to
+17
| ### Changed | ||
| - Dropped support for Chia log formats prior to 2.6.0. The harvester activity parser now only | ||
| supports the Chia 2.6.0+ log format (`challenge_hash:` prefix, V1/V2 proof counts). |
Owner
There was a problem hiding this comment.
Any folks lurking / seeing this PR, could you comment whether this is acceptable? I'm not sure how many folks are out there running older versions and relying on chiadog so it's not ideal to lose backwards compatability. Would it be possible to keep backward/forward compatibility in the regex as we've been able to do in the past?
martomi
reviewed
Apr 16, 2026
martomi
left a comment
martomi
left a comment
Owner
There was a problem hiding this comment.
Thanks for this. Seems reasonable. Ideally we would maintain backward compatibility for older versions have you tried asking claude/codex to implement that way? I feel like it should be fairly easy based on existing patterns.
|
I think it is also still not working in 2.7.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusts test fixtures and logic to match the 2.6.0 log format, which should fix:
#395
#394
#392
There are other PRs that likely address the same issues, but they also change a lot of logic. Since I'm not deeply familiar with chiadog's internals, I'll leave it to @martomi to decide which approach is better and merge or adjust accordingly.
Testing: I've been running the Docker image with this change for a few days and it works as expected. I use the Slack notifier.